[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] small patches

From: Jonathan Rosser
Subject: Re: [Linphone-developers] small patches
Date: Wed, 07 Nov 2012 11:41:30 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121011 Thunderbird/16.0.1

On 11/07/12 11:03, Guillaume Beraudo wrote:
> Hi Jonathan,
> Thank you for your patches and sorry for the late response.
> I have merged the patches 2 and 3 in mediastreamer.
> However I don't understand patch 1.
> The video window is composed of:
> - remote video (also called main video);
> - self-view in a corner (also called local preview).
> What issue are you trying to fix?

When the application is first opened, i.e. not in a call, the aspect
ratio of the self view (which takes the whole window) is I think wrong
when using a 16:9 source. It fills the whole square-ish window and does
not have black bars at the top and bottom.

The function x11video_set_vsize() appears to actually set s->wsize,
which I think is the cause of this error. Things then go wrong in

Does this make sense?

Thanks for applying the other patches.

Best Regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]