[lmi-commits] [6184] Remove warnings about preferred loans: they'll be supported soon

[Greg Chicares]

Revision: 6184
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6184
Author:   chicares
Date:     2015-05-02 15:22:51 +0000 (Sat, 02 May 2015)
Log Message:
-----------
Remove warnings about preferred loans: they'll be supported soon

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/dbnames.xpp
    lmi/trunk/ihs_avmly.cpp
    lmi/trunk/interest_rates.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2015-05-02 14:29:12 UTC (rev 6183)
+++ lmi/trunk/ChangeLog 2015-05-02 15:22:51 UTC (rev 6184)
@@ -36181,3 +36181,16 @@
 anyway because of the ee payment, so the admin system would simply
 have an unneeded extra margin of conservatism.
 
+20150502T1429Z <address@hidden> [513]
+
+  interest_rates.cpp
+  interest_rates.hpp
+Remove latent defects in as-yet-unreachable code.
+
+20150502T1522Z <address@hidden> [513]
+
+  dbnames.xpp
+  ihs_avmly.cpp
+  interest_rates.cpp
+Remove warnings about preferred loans: they'll be supported soon.
+

Modified: lmi/trunk/dbnames.xpp
===================================================================
--- lmi/trunk/dbnames.xpp       2015-05-02 14:29:12 UTC (rev 6183)
+++ lmi/trunk/dbnames.xpp       2015-05-02 15:22:51 UTC (rev 6184)
@@ -257,7 +257,7 @@
 {DB_FirstWdMonth,DB_Topic_Withdrawals,"FirstWdMonth","Number of months 
withdrawals not allowed [not supported yet]",}, \
 {DB_Topic_Loans,DB_FIRST,"Loans","Loan rates, spreads, options, and 
restrictions",}, \
 {DB_AllowLoan,DB_Topic_Loans,"AllowLoan","Allow loans: 0=no, 1=yes",}, \
-{DB_AllowPrefLoan,DB_Topic_Loans,"AllowPrefLoan","Preferred loans permitted: 
0=no, 1=yes [preferred loans not yet supported]",}, \
+{DB_AllowPrefLoan,DB_Topic_Loans,"AllowPrefLoan","Preferred loans permitted: 
0=no, 1=yes",}, \
 {DB_AllowFixedLoan,DB_Topic_Loans,"AllowFixedLoan","Fixed-rate loans 
permitted: 0=no, 1=yes",}, \
 {DB_AllowVlr,DB_Topic_Loans,"AllowVlr","Variable-rate loans permitted: 0=no, 
1=yes",}, \
 {DB_FixedLoanRate,DB_Topic_Loans,"FixedLoanRate","Fixed loan rate, e.g. .06 = 
6%",}, \
@@ -265,9 +265,9 @@
 {DB_MinVlrRate,DB_Topic_Loans,"MinVlrRate","Minimum variable loan rate",}, \
 {DB_MaxLoanAcctValMult,DB_Topic_Loans,"MaxLoanAcctValMult","Maximum loan as 
proportion of account value, e.g. 1=100%",}, \
 {DB_MaxLoanDed,DB_Topic_Loans,"MaxLoanDed","Monthiversary deductions reflected 
in maximum loan: 0=12 times most recent, 1=to next anniversary, 2=to next modal 
premium due date, 3=18 times most recent",}, \
-{DB_GuarPrefLoanSpread,DB_Topic_Loans,"GuarPrefLoanSpread","Guaranteed 
interest spread for preferred loans [preferred loans not yet supported]",}, \
+{DB_GuarPrefLoanSpread,DB_Topic_Loans,"GuarPrefLoanSpread","Guaranteed 
interest spread for preferred loans",}, \
 {DB_GuarRegLoanSpread,DB_Topic_Loans,"GuarRegLoanSpread","Guaranteed interest 
spread for regular loans",}, \
-{DB_CurrPrefLoanSpread,DB_Topic_Loans,"CurrPrefLoanSpread","Current interest 
spread for preferred loans [preferred loans not yet supported]",}, \
+{DB_CurrPrefLoanSpread,DB_Topic_Loans,"CurrPrefLoanSpread","Current interest 
spread for preferred loans",}, \
 {DB_CurrRegLoanSpread,DB_Topic_Loans,"CurrRegLoanSpread","Current interest 
spread for regular loans",}, \
 {DB_FirstLoanMonth,DB_Topic_Loans,"FirstLoanMonth","Number of months loans not 
allowed [not supported yet]",}, \
 {DB_Topic_Premiums,DB_FIRST,"Premiums","Minimum and target premiums",}, \

Modified: lmi/trunk/ihs_avmly.cpp
===================================================================
--- lmi/trunk/ihs_avmly.cpp     2015-05-02 14:29:12 UTC (rev 6183)
+++ lmi/trunk/ihs_avmly.cpp     2015-05-02 15:22:51 UTC (rev 6184)
@@ -2734,9 +2734,6 @@
         return;
         }
 
-    // SOMEDAY !! Preferred loan calculations not yet implemented.
-    LMI_ASSERT(0.0 == AVPrfLn);
-
     double max_loan_increment = MaxLoan - (AVRegLn + AVPrfLn);
 
     // When performing a solve, let it become overloaned--otherwise

Modified: lmi/trunk/interest_rates.cpp
===================================================================
--- lmi/trunk/interest_rates.cpp        2015-05-02 14:29:12 UTC (rev 6183)
+++ lmi/trunk/interest_rates.cpp        2015-05-02 15:22:51 UTC (rev 6184)
@@ -667,7 +667,6 @@
             );
         if(NeedPrefLoanRates_)
             {
-            fatal_error() << "Preferred loans not implemented." << LMI_FLUSH;
             convert_interest_rates
                 (PrfLnDueRate_[mce_annual_rate ][j]
                 ,PrfLnDueRate_[mce_annual_rate ][j]