[lmi-commits] [lmi] master 6002d5e: Include <iterator> only where needed, documenting why

[Greg Chicares]

branch: master
commit 6002d5eb359f1b6fed9797fc52b1f1ad0a69abe4
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Include <iterator> only where needed, documenting why
---
 alert_test.cpp                 |    2 +-
 bcc_ld.cpp                     |    2 +-
 calendar_date.cpp              |    2 +-
 census_view.cpp                |    2 +-
 configurable_settings.cpp      |    2 +-
 dbvalue.cpp                    |    5 ++---
 expression_template_0_test.cpp |    2 +-
 ihs_acctval.cpp                |    1 +
 ihs_avdebug.cpp                |    2 +-
 ihs_irc7702.cpp                |    2 +-
 input_seq_test.cpp             |    2 +-
 input_sequence.cpp             |    2 +-
 input_sequence_entry.cpp       |    2 +-
 istream_to_string_test.cpp     |    2 +-
 ledger_base.hpp                |    2 +-
 ledger_text_formats.cpp        |    1 -
 msw_workarounds.cpp            |    2 +-
 xml_serializable.tpp           |    2 +-
 18 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/alert_test.cpp b/alert_test.cpp
index 888f788..8647621 100644
--- a/alert_test.cpp
+++ b/alert_test.cpp
@@ -26,7 +26,7 @@
 #include "test_tools.hpp"
 
 #include <algorithm>
-#include <iterator>
+#include <iterator>                     // std::ostream_iterator
 #include <stdexcept>
 #include <vector>
 
diff --git a/bcc_ld.cpp b/bcc_ld.cpp
index c704a21..05180c8 100644
--- a/bcc_ld.cpp
+++ b/bcc_ld.cpp
@@ -45,7 +45,7 @@
 #include <fstream>
 #include <ios>
 #include <iostream>
-#include <iterator>
+#include <iterator>                     // std::ostream_iterator
 #include <ostream>
 #include <sstream>
 #include <string>
diff --git a/calendar_date.cpp b/calendar_date.cpp
index 9517a1b..6a15c71 100644
--- a/calendar_date.cpp
+++ b/calendar_date.cpp
@@ -33,7 +33,7 @@
 #include <iomanip>
 #include <ios>
 #include <istream>
-#include <iterator>
+#include <iterator>                     // std::ostreambuf_iterator
 #include <locale>
 #include <ostream>
 #include <sstream>
diff --git a/census_view.cpp b/census_view.cpp
index fc59bb9..05b3473 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -60,7 +60,7 @@
 #include <cctype>
 #include <cstddef>                      // std::size_t
 #include <istream>                      // std::ws
-#include <iterator>
+#include <iterator>                     // std::insert_iterator
 #include <sstream>
 
 namespace
diff --git a/configurable_settings.cpp b/configurable_settings.cpp
index 5ed167f..dac8805 100644
--- a/configurable_settings.cpp
+++ b/configurable_settings.cpp
@@ -39,7 +39,7 @@
 #include <boost/filesystem/operations.hpp>
 #include <boost/filesystem/path.hpp>
 
-#include <iterator>
+#include <iterator>                     // std::istream_iterator
 #include <sstream>
 #include <stdexcept>
 
diff --git a/dbvalue.cpp b/dbvalue.cpp
index 9a70497..23ad411 100644
--- a/dbvalue.cpp
+++ b/dbvalue.cpp
@@ -35,10 +35,9 @@
 #include "xml_serialize.hpp"
 
 #include <algorithm>
-#include <functional>
-#include <iterator>                     // std::advance()
+#include <functional>                   // std::multiplies()
 #include <limits>                       // std::numeric_limits
-#include <numeric>
+#include <numeric>                      // std::accumulate()
 #include <ostream>
 
 namespace
diff --git a/expression_template_0_test.cpp b/expression_template_0_test.cpp
index 41e0f99..ddb1de6 100644
--- a/expression_template_0_test.cpp
+++ b/expression_template_0_test.cpp
@@ -50,7 +50,7 @@
 
 #include <algorithm>
 #include <functional>
-#include <iterator>
+#include <iterator>                     // std::back_inserter()
 #include <string>
 #include <valarray>
 #include <vector>
diff --git a/ihs_acctval.cpp b/ihs_acctval.cpp
index eefc2cd..3d5cc46 100644
--- a/ihs_acctval.cpp
+++ b/ihs_acctval.cpp
@@ -51,6 +51,7 @@
 #include <algorithm>
 #include <cmath>
 #include <functional>
+#include <iterator>                     // std::back_inserter()
 #include <limits>
 #include <numeric>
 #include <string>
diff --git a/ihs_avdebug.cpp b/ihs_avdebug.cpp
index c574b66..8efc660 100644
--- a/ihs_avdebug.cpp
+++ b/ihs_avdebug.cpp
@@ -34,7 +34,7 @@
 #include "value_cast.hpp"
 
 #include <algorithm>
-#include <iterator>
+#include <iterator>                     // std::ostream_iterator
 #include <string>
 #include <vector>
 
diff --git a/ihs_irc7702.cpp b/ihs_irc7702.cpp
index 9047ee4..570466f 100644
--- a/ihs_irc7702.cpp
+++ b/ihs_irc7702.cpp
@@ -32,7 +32,7 @@
 #include <algorithm>
 #include <cmath>
 #include <functional>
-#include <iterator>
+#include <iterator>                     // std::advance()
 #include <limits>
 #include <numeric>
 
diff --git a/input_seq_test.cpp b/input_seq_test.cpp
index b3a9f57..4cf4945 100644
--- a/input_seq_test.cpp
+++ b/input_seq_test.cpp
@@ -27,7 +27,7 @@
 
 #include <algorithm>
 #include <cassert>
-#include <iterator>
+#include <iterator>                     // std::ostream_iterator
 
 // Macros don't offer default arguments, so we need one macro
 // for each number of arguments.
diff --git a/input_sequence.cpp b/input_sequence.cpp
index f57b814..18b42fb 100644
--- a/input_sequence.cpp
+++ b/input_sequence.cpp
@@ -33,7 +33,7 @@
 #include <cctype>
 #include <ios>
 #include <istream>
-#include <iterator>
+#include <iterator>                     // std::ostream_iterator
 #include <ostream>
 #include <sstream>
 
diff --git a/input_sequence_entry.cpp b/input_sequence_entry.cpp
index 645fa31..7a578a7 100644
--- a/input_sequence_entry.cpp
+++ b/input_sequence_entry.cpp
@@ -50,7 +50,7 @@
 #include <wx/valtext.h>
 
 #include <algorithm>                    // std::copy()
-#include <iterator>                     // std::back_inserter
+#include <iterator>                     // std::back_inserter()
 #include <map>
 #include <vector>
 
diff --git a/istream_to_string_test.cpp b/istream_to_string_test.cpp
index 2bf270e..efe61bd 100644
--- a/istream_to_string_test.cpp
+++ b/istream_to_string_test.cpp
@@ -29,7 +29,7 @@
 
 #include <cstdio>
 #include <fstream>
-#include <iterator>
+#include <iterator>                     // std::istreambuf_iterator
 
 template<typename Char_t, typename Traits, typename Allocator>
 void istream_to_string_1
diff --git a/ledger_base.hpp b/ledger_base.hpp
index 4ec03a4..d24a332 100644
--- a/ledger_base.hpp
+++ b/ledger_base.hpp
@@ -33,7 +33,7 @@
 #include <iomanip>
 #include <ios>
 #include <iosfwd>
-#include <iterator>
+#include <iterator>                     // std::ostream_iterator
 #include <map>
 #include <string>
 #include <vector>
diff --git a/ledger_text_formats.cpp b/ledger_text_formats.cpp
index c8a7cf5..082de8f 100644
--- a/ledger_text_formats.cpp
+++ b/ledger_text_formats.cpp
@@ -45,7 +45,6 @@
 #include <fstream>
 #include <iomanip>
 #include <ios>
-#include <iterator>
 #include <locale>
 #include <map>
 #include <ostream>
diff --git a/msw_workarounds.cpp b/msw_workarounds.cpp
index a1a6831..1f661c3 100644
--- a/msw_workarounds.cpp
+++ b/msw_workarounds.cpp
@@ -36,7 +36,7 @@
 
 #include <algorithm>
 #include <functional>
-#include <iterator>
+#include <iterator>                     // std::istream_iterator
 #include <sstream>
 
 MswDllPreloader::MswDllPreloader()
diff --git a/xml_serializable.tpp b/xml_serializable.tpp
index 9260d7d..9729c5a 100644
--- a/xml_serializable.tpp
+++ b/xml_serializable.tpp
@@ -33,7 +33,7 @@
 #include <xmlwrapp/nodes_view.h>
 
 #include <algorithm>                    // std::copy(), std::find()
-#include <iterator>                     // std::back_inserter
+#include <iterator>                     // std::back_inserter()
 #include <sstream>
 #include <type_traits>
 #include <vector>