[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master ffb020e 3/4: Make const accessors return by c
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master ffb020e 3/4: Make const accessors return by const&, not by value |
Date: |
Mon, 30 Jan 2017 14:12:28 +0000 (UTC) |
branch: master
commit ffb020ec192580e03ae6f92ee4d8b4924b59722d
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Make const accessors return by const&, not by value
---
input_sequence.cpp | 4 ++--
input_sequence.hpp | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/input_sequence.cpp b/input_sequence.cpp
index ffacb1e..28c1af9 100644
--- a/input_sequence.cpp
+++ b/input_sequence.cpp
@@ -991,12 +991,12 @@ std::string InputSequence::formatted_diagnostics
return s;
}
-std::vector<double> InputSequence::linear_number_representation() const
+std::vector<double> const& InputSequence::linear_number_representation() const
{
return number_result;
}
-std::vector<std::string> InputSequence::linear_keyword_representation() const
+std::vector<std::string> const& InputSequence::linear_keyword_representation()
const
{
return keyword_result;
}
diff --git a/input_sequence.hpp b/input_sequence.hpp
index 1d9ce38..ffadebd 100644
--- a/input_sequence.hpp
+++ b/input_sequence.hpp
@@ -257,9 +257,8 @@ class LMI_SO InputSequence
);
~InputSequence();
- // SOMEDAY !! These probably ought to return const&.
- std::vector<double> linear_number_representation() const;
- std::vector<std::string> linear_keyword_representation() const;
+ std::vector<double> const& linear_number_representation() const;
+ std::vector<std::string> const& linear_keyword_representation() const;
std::string mathematical_representation() const;