[lmi-commits] [lmi] master ac17f79 4/6: Add and remove defect markers [380]

[Greg Chicares]

branch: master
commit ac17f798a1e3046cee7c0c61cb9e713ebef19fd1
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Add and remove defect markers [380]
    
    Reasons for removals:
      spouse and child rider amounts: appropriately totalled on composites
      spouse issue age: zero on composites--no other value would be better
---
 ledger_invariant.cpp | 8 --------
 ledger_invariant.hpp | 2 ++
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/ledger_invariant.cpp b/ledger_invariant.cpp
index 83fbb21..0c1bfc3 100644
--- a/ledger_invariant.cpp
+++ b/ledger_invariant.cpp
@@ -1208,17 +1208,9 @@ LedgerInvariant& LedgerInvariant::PlusEq(LedgerInvariant 
const& a_Addend)
     HasTerm         = HasTerm         || a_Addend.HasTerm        ;
     HasSupplSpecAmt = HasSupplSpecAmt || a_Addend.HasSupplSpecAmt;
 
-// TODO ?? Can these be meaningful on a composite? If totals are desired,
-// then term should be treated the same way.
-//    ChildRiderAmount   = ChildRiderAmount   || a_Addend.ChildRiderAmount  ;
-//    SpouseRiderAmount  = SpouseRiderAmount  || a_Addend.SpouseRiderAmount ;
-
     HasChildRider      = HasChildRider      || a_Addend.HasChildRider     ;
     HasSpouseRider     = HasSpouseRider     || a_Addend.HasSpouseRider    ;
 
-// TODO ?? For some ages, we use min; for others, max; how about this one?
-//    SpouseIssueAge     =
-
     HasHoneymoon       = HasHoneymoon || a_Addend.HasHoneymoon ;
     PostHoneymoonSpread= a_Addend.PostHoneymoonSpread          ;
     SplitMinPrem       = SplitMinPrem || a_Addend.SplitMinPrem ;
diff --git a/ledger_invariant.hpp b/ledger_invariant.hpp
index 1383bc2..0937a11 100644
--- a/ledger_invariant.hpp
+++ b/ledger_invariant.hpp
@@ -103,6 +103,8 @@ class LMI_SO LedgerInvariant
     std::vector<double> AddonCompOnAssets;
     std::vector<double> AddonCompOnPremium;
     std::vector<double> CorridorFactor;
+    // TODO ?? M&E varies by basis (cf. 'GuarMaxMandE' below), so it
+    // belongs in the variant ledger.
     std::vector<double> CurrMandE;
     // TODO ?? This is misbegotten. It's supposed to mean IMF including
     // any tiered component, but in that case it would vary by basis.