[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 5548922 14/16: Avoid gratuitous use of member
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 5548922 14/16: Avoid gratuitous use of member size() |
Date: |
Thu, 15 Nov 2018 17:37:05 -0500 (EST) |
branch: master
commit 55489224f0b46609a18d0c58bbd0ec056f355987
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Avoid gratuitous use of member size()
---
calendar_date_test.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/calendar_date_test.cpp b/calendar_date_test.cpp
index dda16ae..692be45 100644
--- a/calendar_date_test.cpp
+++ b/calendar_date_test.cpp
@@ -1077,7 +1077,7 @@ void CalendarDateTest::TestIo()
// bodies of these speed-test functions. For now, writing to a quasi-
// global volatile variable is intended to serve that function, though
// it's difficult to be sure it's correctly used in each case, and
-// calling julian_day_number() or size() just to get a value to write
+// calling julian_day_number() or empty() just to get a value to write
// to that volatile variable is an ugly artifice.
namespace
@@ -1091,7 +1091,7 @@ void mete()
calendar_date u(2525, 12, 31);
t = u;
++t;
- scupper = t.str().size();
+ scupper = t.str().empty();
t = add_years_and_months(t, 1, 1, true);
scupper = attained_age(u, t, oe_age_last_birthday);
u = minimum_birthdate(45, t, oe_age_last_birthday);
@@ -1132,7 +1132,7 @@ void mete_get_y_m_d()
void mete_format()
{
static const calendar_date t(7510, 12, 31);
- scupper = t.str().size();
+ scupper = t.str().empty();
}
void mete_attained_age()
- [lmi-commits] [lmi] master 08e2d4c 03/16: Truncate sizeof(char*), (continued)
- [lmi-commits] [lmi] master 08e2d4c 03/16: Truncate sizeof(char*), Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 327d53c 06/16: Conditionally suppress selected x86_64-linux-gnu gcc-8 diagnostics, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master a1c1aa0 11/16: Avoid type 'long int', Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 158c2a1 08/16: Suppress x86_64-linux-gnu gcc-8 diagnostics for xmlwrapp, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master db0c484 02/16: Improve default gcc warning options, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master d425a61 10/16: Suppress some 86_64-linux-gnu gcc-8 '-Wconversion' diagnostics, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 9c34f2a 12/16: Don't mix std::size_t with fixed-width integer types, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 89e939b 16/16: Prefer lmi::ssize() to member size(), Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 0c4c5b6 01/16: Improve gcc dialect defaults, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 96dc6f5 07/16: Suppress certain diagnostics for another old boost library, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 5548922 14/16: Avoid gratuitous use of member size(),
Greg Chicares <=
- [lmi-commits] [lmi] master fc8cf69 13/16: Prefer lmi::ssize() to member size(); rewrite a function out of line, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master f0fd0dc 15/16: Use bourn_cast to convert arithmetic types safely, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master c0a4dde 04/16: Reliably multiply suseconds_t by double, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master 0d09e74 05/16: Make a macro definition conditional, Greg Chicares, 2018/11/15
- [lmi-commits] [lmi] master a00f295 09/16: Avoid std::ptrdiff_t where it's excessively wide for 64-bit builds, Greg Chicares, 2018/11/15