lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 36ce5cc: Prefer more robust 'find' commands


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 36ce5cc: Prefer more robust 'find' commands
Date: Wed, 29 Apr 2020 16:27:38 -0400 (EDT)

branch: master
commit 36ce5cc22ef4e8fe47fd6f5e3a474edd9e1740a8
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Prefer more robust 'find' commands
    
    See:
      https://lists.nongnu.org/archive/html/lmi/2020-04/msg00017.html
    et seq.
---
 gwc/share_git1.sh | 14 ++++----------
 gwc/share_git2.sh | 14 ++++----------
 2 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/gwc/share_git1.sh b/gwc/share_git1.sh
index 7def654..aa08a43 100755
--- a/gwc/share_git1.sh
+++ b/gwc/share_git1.sh
@@ -116,18 +116,12 @@ git -C "$inited" fsck
 #   stat --printf="%A %a\t%U %G %n\n" $(find .) |sed ...
 # could be used instead of 'ls', but the gain in robustness doesn't
 # seem worth the loss in readability.
-# shellcheck disable=SC2012
-# shellcheck disable=SC2046
-ls -ld $(find .) |sed -e'/^.....w/d' -e'/objects\/pack/d'
+find . -print0 | xargs -0 ls -ld |sed -e'/^.....w/d' -e'/objects\/pack/d'
 
 # Show any files whose GID isn't "audio", expecting '.' only.
-# shellcheck disable=SC2012
-# shellcheck disable=SC2046
-ls -ld $(find .) |sed -e'/ audio /d'
+find . -print0 | xargs -0 ls -ld |sed -e'/ audio /d'
 
 # List all files' permissions for comparison, e.g.:
 #   meld /srv/chroot/bullseye0/tmp/eraseme/ls-* &
-# shellcheck disable=SC2046
-(cd "$inited" && ls -ld $(find .)) > ls-"$inited"
-# shellcheck disable=SC2046
-(cd "$cloned" && ls -ld $(find .)) > ls-"$cloned"
+(cd "$inited" && find . -print0 | xargs -0 ls -ld) > ls-"$inited"
+(cd "$cloned" && find . -print0 | xargs -0 ls -ld) > ls-"$cloned"
diff --git a/gwc/share_git2.sh b/gwc/share_git2.sh
index 787ace0..aded7cf 100755
--- a/gwc/share_git2.sh
+++ b/gwc/share_git2.sh
@@ -121,18 +121,12 @@ git -C "$inited" fsck
 #   stat --printf="%A %a\t%U %G %n\n" $(find .) |sed ...
 # could be used instead of 'ls', but the gain in robustness doesn't
 # seem worth the loss in readability.
-# shellcheck disable=SC2012
-# shellcheck disable=SC2046
-ls -ld $(find .) |sed -e'/^.....w/d' -e'/objects\/pack/d'
+find . -print0 | xargs -0 ls -ld |sed -e'/^.....w/d' -e'/objects\/pack/d'
 
 # Show any files whose GID isn't "audio", expecting '.' only.
-# shellcheck disable=SC2012
-# shellcheck disable=SC2046
-ls -ld $(find .) |sed -e'/ audio /d'
+find . -print0 | xargs -0 ls -ld |sed -e'/ audio /d'
 
 # List all files' permissions for comparison, e.g.:
 #   meld /srv/chroot/bullseye0/tmp/eraseme/ls-* &
-# shellcheck disable=SC2046
-(cd "$inited" && ls -ld $(find .)) > ls-"$inited"
-# shellcheck disable=SC2046
-(cd "$cloned" && ls -ld $(find .)) > ls-"$cloned"
+(cd "$inited" && find . -print0 | xargs -0 ls -ld) > ls-"$inited"
+(cd "$cloned" && find . -print0 | xargs -0 ls -ld) > ls-"$cloned"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]