[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 810de0a 26/46: Remove unnecessary wxGrid::IsC
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 810de0a 26/46: Remove unnecessary wxGrid::IsCellEditControlEnabled() calls |
Date: |
Wed, 22 Jul 2020 11:05:13 -0400 (EDT) |
branch: master
commit 810de0a35174efef2173f6ba5ea81cb338c7eefe
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>
Remove unnecessary wxGrid::IsCellEditControlEnabled() calls
There is no need to check for the edit control being enabled before
calling DisableCellEditControl(), the latter simply won't do anything if
there is no edit control to disable.
---
census_view.cpp | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/census_view.cpp b/census_view.cpp
index e37eda6..453d4b3 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -2253,10 +2253,7 @@ void CensusGridView::update_visible_columns()
wxGridUpdateLocker grid_update_locker(grid_window_);
- if(grid_window_->IsCellEditControlEnabled())
- {
- grid_window_->DisableCellEditControl();
- }
+ grid_window_->DisableCellEditControl();
grid_table_->set_visible_columns(std::move(new_visible_columns));
@@ -3194,11 +3191,7 @@ void CensusGridView::UponPasteCensus(wxCommandEvent&)
wxGridUpdateLocker grid_update_locker(grid_window_);
grid_window_->ClearSelection();
-
- if(grid_window_->IsCellEditControlEnabled())
- {
- grid_window_->DisableCellEditControl();
- }
+ grid_window_->DisableCellEditControl();
if(old_rows != new_rows || old_cols != new_cols)
{
- [lmi-commits] [lmi] master ece93a0 17/46: Make check for Alt-Enter more obvious in the code, (continued)
- [lmi-commits] [lmi] master ece93a0 17/46: Make check for Alt-Enter more obvious in the code, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b57ed4a 18/46: Remove deleted DatumSequenceEditor copy-related methods, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 041ccfc 30/46: Optimize changing grid columns number too, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 53a288a 33/46: Restore "delete_cells" update UI handler for CensusDVCView, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 3c3d0c0 36/46: Explain grid customizations in the function creating it, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 337d81f 37/46: Make UponDeleteCells() more efficient for large censuses, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 2922db9 44/46: Disallow single cell operations when non-current row is selected, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master d337a22 45/46: Upgrade wx, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master c679655 19/46: Replace table_type_converter::get_all() with register_all(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 7dc508e 35/46: Don't select the first row initially in the grid census view, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master 810de0a 26/46: Remove unnecessary wxGrid::IsCellEditControlEnabled() calls,
Greg Chicares <=
- [lmi-commits] [lmi] master adc4089 28/46: Optimize changing grid dimensions when pasting into the census, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master be4c2a4 32/46: Add a comment explaining why the first column is read-only, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b7944ba 38/46: Resize only columns, not rows, in update_visible_columns(), Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master b399a7d 40/46: Remove automatic column auto-sizing in wxGrid-based census view, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master d4ad57b 42/46: Disallow "Edit/Run" cell when multiple grid rows are selected, Greg Chicares, 2020/07/22
- [lmi-commits] [lmi] master d39ff1d 07/46: Use wxGridCellAttrPtr instead of manual reference counting, Greg Chicares, 2020/07/22