[lmi-commits] [lmi] master 7837f36 5/6: Fix defect introduced 20050114T1947Z: function call with no effect

[Greg Chicares]

branch: master
commit 7837f36d6f9249439cffa4eb633ab89c8f76b4d2
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Fix defect introduced 20050114T1947Z: function call with no effect
    
    Although this defect was introduced 20050114T1947Z into CVS, it comes
    from an original file predating the lmi epoch, which contained:
    
        round_interest_rate(tiered_load_amd);
    
    which calculates and discards the rounded value of its (unaffected)
    argument.
    
    This change has no effect on any of lmi's 1500 or so regression tests,
    but presumably some ancient product reaches this obscure corner of the
    code. Gave force to the original intention, which seems reasonable
    enough: a dynamic separate-account load is in the nature of a decrement
    to the interest rate.
    
    The actual resulting fund increment, SepAcctLoad, has never been, but
    should always have been, and soon will be, rounded.
---
 ihs_avmly.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ihs_avmly.cpp b/ihs_avmly.cpp
index 0d748aa..e81cb58 100644
--- a/ihs_avmly.cpp
+++ b/ihs_avmly.cpp
@@ -1972,7 +1972,7 @@ void AccountValue::TxTakeSepAcctLoad()
         YearsSepAcctLoadRate += stratified_load;
         YearsSepAcctLoadRate += tiered_comp;
         YearsSepAcctLoadRate = 
i_upper_12_over_12_from_i<double>()(YearsSepAcctLoadRate);
-        round_interest_rate()(YearsSepAcctLoadRate);
+        YearsSepAcctLoadRate = round_interest_rate()(YearsSepAcctLoadRate);
         }
 
     SepAcctLoad = YearsSepAcctLoadRate * AVSepAcct;