[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 61f5559: Don't hash non-existent file in CI "

From: Vadim Zeitlin
Subject: [lmi-commits] [lmi] master 61f5559: Don't hash non-existent file in CI "download archives" step
Date: Wed, 7 Oct 2020 13:07:21 -0400 (EDT)

branch: master
commit 61f5559451ac3a288a931a4693f205d1406fcb2f
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>

    Don't hash non-existent file in CI "download archives" step
    install_libxml2_libxslt.make doesn't exist any more and
    install_libxml2_libxsl.sh replacing it doesn't download anything, so we
    don't need to include the hash of this file in the cache key for the
    downloaded files any more.
    This should have been done in d217f203a (Fix GitHub CI to use
    lib{xml2,xslt} submodules, 2020-09-30), but was forgotten there.
 .github/workflows/ci.yml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0aa7c1f..859012b 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -58,12 +58,13 @@ jobs:
       - name: Cache downloaded archives
         uses: actions/cache@v2
-          # Use combined key for files downloaded by both makefiles, even
-          # though this means that we would redownload the same files from the
-          # unchanged makefile if only one of them changes -- but they don't
-          # change often enough to make this a real problem in practice.
+          # Using the hash of the makefile means that we're going to have
+          # false negatives, i.e. re-download the files unnecessarily if the
+          # makefile changes but the MD5 checksums of the files in it do not,
+          # but this is much simpler than extracting those MD5s from it and it
+          # changes rarely enough that this shouldn't be a problem in practice.
           path: /srv/cache_for_lmi/downloads
-          key: downloads-${{ hashFiles('install_miscellanea.make') }}-${{ 
hashFiles('install_libxml2_libxslt.make') }}
+          key: downloads-${{ hashFiles('install_miscellanea.make') }}
       - name: Build miscellanea
         run: make $coefficiency --output-sync=recurse -f 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]