[lmi-commits] [lmi] master f74f14c 06/15: Avoid non-const reference arguments

[Greg Chicares]

branch: master
commit f74f14c3c74eee30f47b6bc55d4df3283b053670
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Avoid non-const reference arguments
    
    These arguments weren't even modified.
---
 interest_rates.cpp | 8 +++-----
 interest_rates.hpp | 6 +++---
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/interest_rates.cpp b/interest_rates.cpp
index 5c3a8be..40655f5 100644
--- a/interest_rates.cpp
+++ b/interest_rates.cpp
@@ -853,15 +853,13 @@ void InterestRates::DynamicMlySepAcctRate
     (mcenum_gen_basis gen_basis
     ,mcenum_sep_basis sep_basis
     ,int              year
-    ,double&          AnnualSepAcctMandERate
-    ,double&          AnnualSepAcctIMFRate
-    ,double&          AnnualSepAcctMiscChargeRate
+    ,double           AnnualSepAcctMandERate
+    ,double           AnnualSepAcctIMFRate
+    ,double           AnnualSepAcctMiscChargeRate
     )
 {
     InvestmentManagementFee_[year] += AnnualSepAcctIMFRate;
     AnnualSepAcctMiscChargeRate    += ExtraSepAcctCharge_    [year];
-// TODO ?? Reference argument 'AnnualSepAcctMandERate' is not modified.
-// Shouldn't it be?
 
     double dynamic_spread =
             AnnualSepAcctMandERate
diff --git a/interest_rates.hpp b/interest_rates.hpp
index 3767ef8..3753da5 100644
--- a/interest_rates.hpp
+++ b/interest_rates.hpp
@@ -167,9 +167,9 @@ class InterestRates
         (mcenum_gen_basis gen_basis
         ,mcenum_sep_basis sep_basis
         ,int              year
-        ,double&          AnnualSepAcctMandERate
-        ,double&          AnnualSepAcctIMFRate
-        ,double&          AnnualSepAcctMiscChargeRate
+        ,double           AnnualSepAcctMandERate
+        ,double           AnnualSepAcctIMFRate
+        ,double           AnnualSepAcctMiscChargeRate
         );
 
     std::vector<double> const& RegLoanSpread