[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 2e84c56 03/14: Rearrange comments
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 2e84c56 03/14: Rearrange comments |
Date: |
Thu, 18 Feb 2021 12:03:40 -0500 (EST) |
branch: master
commit 2e84c565183bbb3ddc21f1b93b061f6bd54ff046
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Rearrange comments
---
ihs_irc7702.cpp | 36 +++++++++++++++++++-----------------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/ihs_irc7702.cpp b/ihs_irc7702.cpp
index 15ecfd7..62a0181 100644
--- a/ihs_irc7702.cpp
+++ b/ihs_irc7702.cpp
@@ -504,14 +504,25 @@ void Irc7702::InitCorridor()
);
}
-//============================================================================
-// TAXATION !! Combine assertions and move to top for clarity.
-// TAXATION !! Combine locals like ann_chg_pol and mly_chg_pol.
-// TAXATION !! Eliminate aliasing references.
-// TAXATION !! Rename '[46]Pct' to 'g[ls]p'.
-// TAXATION !! Write a utility function for rotate-partial_sum_rotate.
-// TAXATION !! Eliminate PvLoadDiff{Sgl,Lvl} if unneeded.
-// TAXATION !! Add unit tests.
+/// Initialize present-value vectors: '7702.html' [14].
+///
+/// kD * MlyChg implies k == mly; it would be more general to say
+/// "modal" instead. But that's still not perfectly general, because
+/// we may need commutation functions on more than one non-annual
+/// mode. For instance, a policy might deduct the policy fee monthly
+/// but the account value load daily. Any specific changes like that
+/// are straightforward, but we don't want to spend time calculating
+/// functions on every conceivable mode unless we're actually going
+/// to use them.
+///
+/// TAXATION !! Combine assertions and move to top for clarity.
+/// TAXATION !! Combine locals like ann_chg_pol and mly_chg_pol.
+/// TAXATION !! Eliminate aliasing references.
+/// TAXATION !! Rename '[46]Pct' to 'g[ls]p'.
+/// TAXATION !! Write a utility function for rotate-partial_sum_rotate.
+/// TAXATION !! Eliminate PvLoadDiff{Sgl,Lvl} if unneeded.
+/// TAXATION !! Add unit tests.
+
void Irc7702::InitPvVectors(EIOBasis const& a_EIOBasis)
{
// We may need to recalculate these every year for a
@@ -528,15 +539,6 @@ void Irc7702::InitPvVectors(EIOBasis const& a_EIOBasis)
LMI_ASSERT(Length == lmi::ssize(comm_fns.aD()));
ann_chg_pol += AnnChgPol * comm_fns.aD();
-// kD * MlyChg implies k == mly; it would be more general to say
-// "modal" instead. But that's still not perfectly general, because
-// we may need commutation functions on more than one non-annual
-// mode. For instance, a policy might deduct the policy fee monthly
-// but the account value load daily. Any specific changes like that
-// are straightforward, but we don't want to spend time calculating
-// functions on every conceivable mode unless we're actually going
-// to use them.
-
std::vector<double> mly_chg_pol(Length);
LMI_ASSERT(Length == lmi::ssize(mly_chg_pol));
LMI_ASSERT(Length == lmi::ssize(MlyChgPol));
- [lmi-commits] [lmi] master updated (f0a4840 -> 7dd2680), Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 2e84c56 03/14: Rearrange comments,
Greg Chicares <=
- [lmi-commits] [lmi] master 5623352 06/14: Remove pointless assertions, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 140c288 05/14: Remove dead code [304], Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 3edb81f 12/14: Add and use a backward-summation function template, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master bff8d5b 04/14: Note a possible defect, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 387657b 08/14: Move assertions upward, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 074ed9e 07/14: Eliminate some local variables, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 18a189a 11/14: Remove duplicate assertions, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master cef60d4 09/14: Strengthen assertions, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 9c580de 01/14: Improve documentation, Greg Chicares, 2021/02/18
- [lmi-commits] [lmi] master 80fce3e 02/14: Rename a member function for clarity, Greg Chicares, 2021/02/18