[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 447290e 04/25: Move an assertion; rewrite and
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 447290e 04/25: Move an assertion; rewrite and duplicate its comment |
Date: |
Wed, 24 Feb 2021 19:00:51 -0500 (EST) |
branch: master
commit 447290e773adaed5a67a2b4a7946ed6efd93d952
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Move an assertion; rewrite and duplicate its comment
Move an assertion outside a block of code that's about to be moved.
Its (improved) comment is wanted both within and outside that block.
---
ihs_basicval.cpp | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/ihs_basicval.cpp b/ihs_basicval.cpp
index cb3aa48..2477086 100644
--- a/ihs_basicval.cpp
+++ b/ihs_basicval.cpp
@@ -420,6 +420,15 @@ void BasicValues::Init7702()
// (optionally) rounding monthly COI rates.
MlyDcvqc = round_coi_rate()(Mly7702qc);
+ // If lmi someday implements VLR, then the current VLR rate on
+ // the issue date constitutes a short-term guarantee that must be
+ // reflected in the 7702 interest rates (excluding the GLP rate).
+ // Until then, assert that VLR is not used, or cannot be used:
+ LMI_ASSERT
+ ( false == database().query<bool>(DB_AllowVlr)
+ || mce_variable_loan_rate != yare_input_.LoanRateType
+ );
+
// Monthly guar net int for 7702 is
// greater of {iglp(), igsp()} and annual guar int rate
// less 7702 spread
@@ -460,13 +469,8 @@ void BasicValues::Init7702()
}
// If lmi someday implements VLR, then the current VLR rate on
- // the issue date constitutes a short-term guarantee that must
- // be reflected here. Until then, assert that VLR is not used,
- // or cannot be used:
- LMI_ASSERT
- ( false == database().query<bool>(DB_AllowVlr)
- || mce_variable_loan_rate != yare_input_.LoanRateType
- );
+ // the issue date constitutes a short-term guarantee that must be
+ // reflected in the 7702 interest rates (excluding the GLP rate).
Mly7702iGlp.assign(Length, 0.0);
assign
- [lmi-commits] [lmi] master updated (a62fbec -> 2f74b41), Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 04484e6 03/25: Remove a duplicative defect marker [300], Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 671e3f2 05/25: Almost move two blocks of code, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 3ba52f9 01/25: Add a '7702 !!' marker for new 7702 issues, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 447290e 04/25: Move an assertion; rewrite and duplicate its comment,
Greg Chicares <=
- [lmi-commits] [lmi] master 5dbf2e3 06/25: Validate class i7702, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 2f74b41 25/25: Improve encapsulation of 7702 "spread", Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 3a06237 08/25: Deduplicate, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 3c341a6 10/25: Remove more dead code, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master e6f9397 14/25: Obtain DCV interest rate from i7702 object, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master d17fda2 20/25: Bring bogosity into focus before eradicating it, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master bbe2802 21/25: Reduce bogosity ever so slightly, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 8c27092 24/25: Use correct interest rates for '.mec' input, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master 7cf8204 02/25: Add a 7702 interest-rate class, Greg Chicares, 2021/02/24
- [lmi-commits] [lmi] master ef22f46 07/25: Deduplicate [295], Greg Chicares, 2021/02/24