[lmi-commits] [lmi] master 3f5da577 1/2: Revert "Add temporary statements to debug a script"

[Greg Chicares]

branch: master
commit 3f5da57754182bdcb335822bf53c64b099c8c91f
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Revert "Add temporary statements to debug a script"
    
    This reverts commit b6c641f9cc2c24208eb319b711ea17d738b5453e.
    
    The diagnostic statements removed here were correctly written to file
    'debian-log_*'. The conditional filtering on `tty -s` affects only
    output that would be written to the screen, not output written to the
    nychthemeral test's log directory, in this pipeline:
    
      | tee "$log_dir"/nychthemeral_test | sed -e "$nychthemeral_clutter"
        ^^^^^^^^^^^nonfiltered^^^^^^^^^^   ^^^^^^^^^^^filtered^^^^^^^^^^^
    
    Thus, when a nychthemeral test is run in the normal way, the presence
    of any output other than the architecture-naming progress indicators
    indicates an actual error; but when it's run as
      nohup /wherever/opt/lmi/src/lmi/gwc/redhat_rebuild.sh & disown; exit
    nothing can we written to the screen because there is no tty. Either
    way, unwanted 'wine' messages appear in "$log_dir"/nychthemeral_test;
    no attempt is currently made to filter them because they're pervasive
    yet 'wine' provides no fine-grained facility to suppress them--see:
      https://lists.nongnu.org/archive/html/lmi/2023-01/msg00019.html
    and suppressing whole categories of important messages with $WINEDEBUG
    would create a risk that some significant message might be missed.
---
 nychthemeral_test.sh | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/nychthemeral_test.sh b/nychthemeral_test.sh
index cac2f728..a246ed87 100755
--- a/nychthemeral_test.sh
+++ b/nychthemeral_test.sh
@@ -281,10 +281,6 @@ nychthemeral_clutter='
 
 if ! tty -s; then 
nychthemeral_clutter="${absent_tty_clutter}${nychthemeral_clutter}"; fi
 
-# for temporary debugging...
-tty -s || echo "no tty"
-echo "${nychthemeral_clutter}"
-
 # Install a bland 'configurable_settings.xml' for all architectures.
 # This overwrites any existing file, but developers probably won't
 # care, and end users are unaffected. Without this step, the