[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Re: redundant workarounds in 'wx_workarounds.hpp'

From: Greg Chicares
Subject: Re: [lmi] Re: redundant workarounds in 'wx_workarounds.hpp'
Date: Tue, 02 Aug 2005 12:39:14 +0000
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)

On 2005-8-1 23:55 UTC, Greg Chicares wrote:
>>On Mon, 1 Aug 2005 16:59:12 -0400 "Boutin, Wendy" <address@hidden> wrote:

[std::string <-> wxString comparison operators in 'wx_workarounds.hpp'
have become harmful with recent wx releases]

> http://cvs.wxwidgets.org/viewcvs.cgi/wxWidgets/include/wx/msw/setup0.h?annotate=1.210
> | 255 VZ      1.210 // Enable conversion to standard C++ string if 1.
> | 256 RR      1.207 #define wxUSE_STD_STRING  0
> Revision 1.207 of Tue Apr 5 20:16:41 2005 has log message
> | Added switch and define for wxUSE_STD_STRING
> and, if I'm reading the tags correctly, it first appeared in WX_2_6_0 .

That seems to answer the question:
  when did these workarounds become harmful?

It's also interesting to ask:
  when were these workarounds necessary?

I think the answer is that they were
  1.191 necessary
  1.192 no longer necessary [wx-2.5.4]
  1.210 harmful
so I'm going to commit a change that uses these workarounds only if
they were necessary--that is, only if the wx version is prior to
2.5.4 . Wendy, would you please test this change right away, and let
me know if it doesn't work with later wx versions?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]