[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] change file formats to XML

From: Vaclav Slavik
Subject: Re: [lmi] change file formats to XML
Date: Mon, 08 Mar 2010 16:25:58 +0100

On Sat, 2010-03-06 at 17:58 +0000, Greg Chicares wrote:
> OTOH, I suppose your goal was backward compatibility.

Yes. Particularly during the transition period. I kept all "legacy" code
inside easily greppable macro checks so that it's easy to remove old
code when it's no longer needed.

> Syntactically valid xml files were written with incorrect contents.
> I don't know whether that's an xmlwrapp issue or not. 

I'd argue it is: I'd expect xml::node(xml::node::text("M&E")) to write
"M&E" into the file. Or maybe throw, but certainly not write "M"
silently and pretend everything is fine. I have similar expectation from
xml::node::set_content(), but that one may be less clear.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]