[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Input-sequence editor integration

From: Vaclav Slavik
Subject: Re: [lmi] Input-sequence editor integration
Date: Tue, 06 Jul 2010 18:25:53 +0200

On Sun, 2010-07-04 at 19:55 +0000, Greg Chicares wrote:
>          // TODO ?? Should not it be moved directly into rounding_view.hpp
>          // or rounding_view_editor.hpp?
>          xml_resources.AddHandler(new(wx) RoundingButtonsXmlHandler);
> +        xml_resources.AddHandler(new(wx) InputSequenceEntryXmlHandler);
> what's your opinion of the comment quoted above? I'd like to either move
> both AddHandler() statements to a better place, or agree that they're in
> the right place already and remove the comment. 

I think this is a good place. As you have to explicitly call
xml_resources.InitAllHandlers() anyway, I prefer to initialize all
handlers in one place, here. Initializing them in different compilation
units is possible via wxModule, but the order of initialization wouldn't
be immediately obvious to the reader.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]