[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] Can we rename lmi.rc or lmi.cpp?

From: Greg Chicares
Subject: Re: [lmi] Can we rename lmi.rc or lmi.cpp?
Date: Thu, 23 Jun 2011 10:51:48 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20110414 Thunderbird/3.1.10

On 2011-06-21 15:07Z, Vadim Zeitlin wrote:
> E.g. for now I renamed lmi.rc to lmi_msw_res.rc locally. Would it be
> acceptable to do it "officially" or should I continue trying to look for
> another solution?

Good idea. Committed 20110623T1036Z, revision 5215.

Please take a look at 'Makefile.am', which needs more work for two
reasons. First, my old workaround:
  foo.cpp --> foo.o
  foo.rc  --> foo.rc.o [with '.rc' inserted in destination name]
was distasteful, so I removed it from 'objects.make', and I suppose it
should likewise be removed from 'Makefile.am'. Second, isn't part of
'Makefile.am' redundant? What do you think of this proposed change?

Index: Makefile.am
--- Makefile.am (revision 5215)
+++ Makefile.am (working copy)
@@ -204,7 +204,10 @@
 ## use old style suffix rule instead of the pattern one as automake only
 ## recognizes the old style rules
+## Vadim--is that comment still applicable? and is this rule necessary,
+## or does a builtin default rule suffice now that we're compiling
+## 'foo.rc' to 'foo.o' instead of 'foo.rc.o'?
        $(WINDRES) -I $(top_srcdir) $(WX_CPPFLAGS) $< $@

     lmi_wx_SOURCES += lmi_msw_res.rc
@@ -217,10 +220,6 @@
     $(GTK_LIBS) \
     $(BOOST_LIBS) \
-    lmi_wx_SOURCES += lmi_msw_res.rc
-    lmi_wx_CXXFLAGS += -mwindows

 cli_sources = \
     alert_cli.cpp \

reply via email to

[Prev in Thread] Current Thread [Next in Thread]