Re: [lmi] [PATCH] Add --gui_test_path command line option to the GUI test.

[Vadim Zeitlin]

On Mon, 15 Dec 2014 13:07:03 +0000 Greg Chicares <address@hidden> wrote:

GC> Committed these four patches:
GC>   20141215T1220Z revision 6071
GC>   20141215T1239Z revision 6072
GC>   20141215T1250Z revision 6073 [the updated patch]
GC>   20141215T1255Z revision 6074

 Perfect, thanks!

GC> Does the gui test path have a default value as follows?
GC> 
GC> http://lists.nongnu.org/archive/html/lmi/2014-12/msg00002.html
GC> | I propose
GC> |   /opt/lmi/gui_test
GC> | as the hardcoded default value to be used if no path is explicitly
GC> | specified.
GC> 
GC> I didn't find it this way:

 Sorry, I had somehow completely missed this and didn't implement it.
Please find attached a patch doing this. Notice that, as written, running
the test will generate a warning by default, i.e. if --gui_test_path option
is not specified and directory /opt/lmi/gui_test doesn't exist. This is not
very user-friendly but OTOH I am not sure what would be the best thing to
do if the default directory doesn't exist (I hesitate between creating
it and just using the current directory silently), and this is not a big
problem in practice as it's enough to just create that directory to get rid
of the warning, so for now I chose the simplest solution which is not to do
anything special.

 Please let me know if you'd like to see this changed,
VZ

0001-Use-opt-lmi-gui_test-as-default-path-for-for-the-tes.patch
Description: Text document