Re: [lmi] [PATCH] wx_test_validate_output.cpp

[Greg Chicares]

On 2015-02-15 00:06, Vadim Zeitlin wrote:
> 
>  Sorry for the delay, but here are, finally, patches implementing the
> requested changes.

Committed
  20150301T1729Z, revision 6112;
  20150301T1747Z, revision 6113;
  20150301T1755Z, revision 6114;
  20150301T2202Z, revision 6115;
  20150301T2325Z, revision 6116;
  20150301T2330Z, revision 6117;
  20150301T2340Z, revision 6118; and
  20150301T2343Z, revision 6119.

I have a question about the seventh patch:
  http://lists.nongnu.org/archive/html/lmi/2015-02/txtiolB8rhO9q.txt
+        // There could be an existing comment in this field, delete it first.
+        // This does assume MSW-like key bindings.
+        ui.Char(WXK_HOME);
+        ui.Char(WXK_END, wxMOD_SHIFT);
+        ui.Char(WXK_BACK);
Will "MSW-like key bindings" cause this not to work with wxGTK?

I've copied my results below. I expect
  default_update: ERROR (Assertion failure: A message box "Unable to read file 
'C:/etc/opt/lmi/default.ill'. [file /lmi/src/lmi/illustration_document.cpp, 
line 110] " was shown unexpectedly, expected defaults dialog. [file 
/lmi/src/lmi/wx_test_default_update.cpp, line 96, in run()].)
until that test is made conditional on '--distribution', but is this error:
  validate_output_census: ERROR (Assertion 'output_values.exists()' failed 
(file "C:/opt/lmi/bin/values.tsv" after print case to PDF). [file 
/lmi/src/lmi/wx_test_validate_output.cpp, line 360] )
expected?

/opt/lmi/bin[0]$./wx_test.exe  --ash_nazg --data_path=/opt/lmi/data
NOTE: starting the test suite
about_dialog_version: started
About dialog version string is "20150116T1757Z".
time=203ms (for about_dialog_version)
about_dialog_version: ok
benchmark_census: started
[...MSEC_* output elided...]
time=113012ms (for benchmark_census)
benchmark_census: ok
calculation_summary: started
time=62339ms (for calculation_summary)
calculation_summary: ok
configurable_settings: started
configurable_settings: skipped (not running distribution tests)
create_open_census: started
time=320ms (for create_open_census)
create_open_census: ok
create_open_database: started
time=2545ms (for create_open_database)
create_open_database: ok
create_open_gpt: started
time=714ms (for create_open_gpt)
create_open_gpt: ok
create_open_illustration: started
time=1994ms (for create_open_illustration)
create_open_illustration: ok
create_open_mec: started
time=587ms (for create_open_mec)
create_open_mec: ok
create_open_policy: started
time=883ms (for create_open_policy)
create_open_policy: ok
create_open_rounding: started
time=1478ms (for create_open_rounding)
create_open_rounding: ok
create_open_strata: started
time=1203ms (for create_open_strata)
create_open_strata: ok
create_open_text: started
time=211ms (for create_open_text)
create_open_text: ok
default_input: started
default_input: skipped (not running distribution tests)
default_update: started
default_update: ERROR (Assertion failure: A message box "Unable to read file 
'C:/etc/opt/lmi/default.ill'. [file /lmi/src/lmi/illustration_document.cpp, 
line 110] " was shown unexpectedly, expected defaults dialog. [file 
/lmi/src/lmi/wx_test_default_update.cpp, line 96, in run()].)
expiry_dates: started
Expiry dates: begin=2450449 (1996-12-31), end=2458849 (2019-12-31)
time=0ms (for expiry_dates)
expiry_dates: ok
input_sequences: started
time=1876ms (for input_sequences)
input_sequences: ok
input_validation: started
time=896ms (for input_validation)
input_validation: ok
paste_census: started
time=3568ms (for paste_census)
paste_census: ok
pdf_census: started
time=5974ms (for pdf_census)
pdf_census: ok
pdf_illustration: started
time=3450ms (for pdf_illustration)
pdf_illustration: ok
validate_output_census: started
validate_output_census: ERROR (Assertion 'output_values.exists()' failed (file 
"C:/opt/lmi/bin/values.tsv" after print case to PDF). [file 
/lmi/src/lmi/wx_test_validate_output.cpp, line 360] )
validate_output_illustration: started
time=2227ms (for validate_output_illustration)
validate_output_illustration: ok
validate_output_mec: started
time=259ms (for validate_output_mec)
validate_output_mec: ok
time=222601ms (for all tests)
FAILURE: 2 out of 24 tests failed.
NOTE: 2 tests were skipped
/opt/lmi/bin[0]$