[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] Allow installing wxWidgets from GitHub

From: Greg Chicares
Subject: Re: [lmi] [PATCH] Allow installing wxWidgets from GitHub
Date: Wed, 05 Aug 2015 23:36:23 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

On 2015-08-05 16:43, Vadim Zeitlin wrote:
> On Wed, 05 Aug 2015 15:09:13 +0000 Greg Chicares <address@hidden> wrote:
>  The --timestamp option only needs to be used to check if the remote file
> is newer than the local one. And while the man page didn't mention it 10
> years ago, it always did behave like this, I took the trouble to look at
> wget sources to confirm it (luckily even wget uses git nowadays so
> exploring its history was simple). If you're interested, the
> --no-use-server-timestamp option was introduced relatively recently
> (January 2010) in these commits
>       http://git.savannah.gnu.org/cgit/wget.git/commit/?id=1f082450
>       http://git.savannah.gnu.org/cgit/wget.git/commit/?id=7585b701
> but before it the code just set the timestamps unconditionally and this
> seems to have been the case since always as the first revision in git
> (imported from svn imported from cvs) repository from 1999-12-02 already
> has it for both HTTP and FTP:
>       http://git.savannah.gnu.org/cgit/wget.git/commit/?id=31d6616c

Thank you. And even if I use this estimable OS
it provides wget-1.11.4, which
dates from "2008-06-29 23:32", so I'm fully satisfied.

> GC> I don't get it. Why do we want '--output-document'? Isn't it better
> GC> without that?
>  No, when you use wx_commit_sha the output of wget would be a local file
> named $(wx_commit_sha).zip which is really not what we want.

Oh. The test I showed downloaded a static file, which is permanently
stored on the server and naturally has a timestamp. When I repeat the
test using wx_commit_sha, I get a file that's created on the fly,
which doesn't have the desired name unless '--output-document' is used.
And it has a current timestamp. (I imagine a meaningful historical
timestamp could be determined by looking up the date of the commit,
but GitHub doesn't do that on the server and I'm not going to do it
myself on the client side.)

Okay, I think I'm ready to write and commit this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]