[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] Integrate wxPdfDocument into lmi build system

From: Greg Chicares
Subject: Re: [lmi] [PATCH] Integrate wxPdfDocument into lmi build system
Date: Fri, 07 Aug 2015 02:05:59 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

On 2015-07-24 00:21, Vadim Zeitlin wrote:
> Don't disable wxRegEx when building wxWidgets.

Committed 20150807T0003Z, revision 6234.

> Handle more options in portable wx-config.

Committed 20150807T0007Z, revision 6235.

> Install wxPdfDocument library as part of lmi installation.

Committed 20150807T0025Z, revision 6236.

> Add a simple unit test for wxPdfDocument.

Committed 20150807T0037Z, revision 6237. I didn't expect the new test
to be added to $(unit_test_targets), and I don't see how it'll link...

wx_pdfdoc_test$(EXEEXT): \
  $(common_test_objects) \
  wx_pdfdoc_test.o \

...without the wxPdfDoc library. But it's not reasonable to rebuild
wx libraries for each of a series of related changes, so I decided to
commit this as is and test it afterward committing all patches.

BTW, grabbing patches from the nongnu.org email archives is convenient
(especially if real email and lmi development are separated by a VM
barrier), but the archives perform interesting substitutions:

-       cd $(cache_dir) && [ -e $@ ] || $(WGET) $(WGETFLAGS) 
--output-document=$@ $(address@hidden)
+       cd $(cache_dir) && [ -e $@ ] || $(WGET) $(WGETFLAGS) 
--output-document=$@ $(address@hidden)
-       cd $(cache_dir) && $(ECHO) "$(address@hidden) *$@" | $(MD5SUM) --check
+       cd $(cache_dir) && $(ECHO) "$(address@hidden) *$@" | $(MD5SUM) --check

reply via email to

[Prev in Thread] Current Thread [Next in Thread]