[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] cgicc changes [Was: Compiling takes longer with gcc-4.9.2]

From: Greg Chicares
Subject: [lmi] cgicc changes [Was: Compiling takes longer with gcc-4.9.2]
Date: Mon, 18 Jan 2016 15:27:33 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0

On 2016-01-18 05:04, Greg Chicares wrote:
> On 2015-12-30 01:10, Vadim Zeitlin wrote:
>> I also had to
>> put "#if __cplusplus < 201103L" around the copy_if() definition in
>> /opt/lmi/third_party/src/cgicc/Cgicc.cpp to make it compile in C++11 mode.
> I modified 'Cgicc.cpp' and 'HTMLElements.cpp' there last month. I'm not
> sure why I modified one more file than you did; perhaps it had a c++03
> problem. I'll have to reexamine those files and update 'cgicc-3.1.4.patch'.

I just committed my changes.

'Cgicc.cpp': I guess that conditionally suppressing the copy_if() definition
worked for you because there's some implicit using-directive in this old
code. But I didn't want to prove that to myself, so I took a more direct
approach. In another place, I added a const_cast that works around some
actual problem with either c++03 or c++11.

'HTMLElements.cpp': This file uses strcmp(), so I added <cstring>. Again,
MinGW-w64 g++ identified a problem here, either with c++03 or with c++11.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]