[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [PATCH] Avoid harmless but annoying arg[cv] shadowing warnings

From: Greg Chicares
Subject: Re: [lmi] [PATCH] Avoid harmless but annoying arg[cv] shadowing warnings
Date: Sat, 4 Jun 2016 17:19:42 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0

On 2016-06-04 14:30, Vadim Zeitlin wrote:
>  After fixing the 2 "possibly uninitialized variables used" warnings in
> a3e46591c01cfc970a715b14b8764002d7eca013, there are just two more (related)
> warnings remaining when building lmi with MSVC 2015 and so, even if it's a
> minor problem, I couldn't prevent myself from fixing it in this patch:
>       https://github.com/vadz/lmi/pull/37
>  As you can see there, it just uses wxApp::arg[cv] directly in
> Skeleton::ProcessCommandLine() instead of passing them to it from
> Skeleton::OnInit() as parameters.

Actually, I can't see it (but I'll apply the patch anyway). I guess
wxApp knows what argc and argv are, and supplies them silently if
they aren't explicitly given.

>  It's not a problem for me to keep this change in a local branch, as I need
> to use it to build with MSVC anyhow, but it's always better to keep the
> differences between it and master to a minimum, so it would be nice if this
> could be applied. It could also allow us to enable -Wshadow (currently
> commented out in workhorse.make) in the future for the gcc builds.

Last sentence--not quite, e.g.:

/opt/lmi/third_party/include/xmlwrapp/node.h: In constructor 
'xml::node::text::text(const char*)':

/opt/lmi/third_party/include/xmlwrapp/node.h:163:42: error: declaration of 
'text' shadows a member of 'this' [-Werror=shadow]

         explicit text (const char *text) : t(text) {}


And a zillion boost errors, and more.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]