lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] [PATCH] Make test_coding_rules_test.sh a bash script


From: Vadim Zeitlin
Subject: [lmi] [PATCH] Make test_coding_rules_test.sh a bash script
Date: Fri, 15 Jul 2016 23:41:27 +0200

 Hello,

 This is so tiny that I didn't bother opening a PR for it as here is the
entire patch:

---------------------------------- >8 --------------------------------------
diff --git a/test_coding_rules_test.sh b/test_coding_rules_test.sh
index fc3d445..9b37198 100755
--- a/test_coding_rules_test.sh
+++ b/test_coding_rules_test.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash

 # Test files for consistency with various rules: unit test.

---------------------------------- >8 --------------------------------------

 However these extra two characters make all the difference because without
them the test fails under Debian, where /bin/sh is dash and doesn't
understand the $'\n' syntax used in this file, unlike bash.

 FWIW I think that maybe avoiding this syntax in the first place could be
even better as there doesn't seem to be any reason to rely on it (even
though it has been recently standardized as part of SUS, apparently, and so
is not really ksh93/bash-specific any more), but for now I'd be glad if
just the change above could be applied.

 TIA,
VZ


reply via email to

[Prev in Thread] Current Thread [Next in Thread]