[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] -Weffc++

From: Vadim Zeitlin
Subject: Re: [lmi] -Weffc++
Date: Thu, 9 Mar 2017 02:39:38 +0100

On Thu, 9 Mar 2017 00:55:58 +0000 Greg Chicares <address@hidden> wrote:

GC> The other 66 lines were all of this worrisome variety:
GC> /opt/lmi/src/lmi/getopt.hpp:136:14: error: 'class GetOpt' has pointer data 
members [-Werror=effc++]
GC> /opt/lmi/src/lmi/getopt.hpp:136:14: error:   but does not override 
'GetOpt(const GetOpt&)' [-Werror=effc++]
GC> /opt/lmi/src/lmi/getopt.hpp:136:14: error:   or 'operator=(const GetOpt&)' 
GC> so I fixed them in commit 040e7c090ace375d5668f0a5701608d8cc0a1eb1.

 Hmm, has this been pushed to Savannah yet? I didn't get a notification
email and the latest commit I see right now (2017-03-09 01:38:34Z) is
still a1cb9c3bc3d810ef523a514a193046fa8f090f63.

GC> Fortunately none of the deleted special member functions were used.

 It's indeed nice that they weren't used and even nicer that the compiler
will now check that this doesn't happen in the future neither, thanks!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]