[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi] [PATCH] Remove unnecessary definitions of pure virtual functions

From: Vadim Zeitlin
Subject: [lmi] [PATCH] Remove unnecessary definitions of pure virtual functions
Date: Wed, 15 Mar 2017 01:46:42 +0100

 Hello again,

 One last patch to fix MSVC build for tonight: this one deals with the same
noreturn-used-in-the-definition-but-not-in-the-declaration problem as the
previous one, but in a quite different way: it simply removes the noreturn
attribute because it also completely removes the function definition which
seems to be completely unnecessary.

 This seemed difficult to believe because I thought there must have been
some reason for having it, but things seem to compile (using MSVC and gcc)
and work (both interactively and the unit tests) just fine without it and
the commit a77e4974b92148155158c23687f58df3424a148e which added these
definitions didn't really explain why did it do it and, contrary to its
message, this wasn't a simple refactoring as the code it added, and which
is removed by the attached patch, hadn't been present before it. So it
seems like it either was a mistake or it was needed 7 years ago, but
something has changed since then and it's not needed any longer. Or I'm
missing something, of course, but this is always an implicit possibility.

 Could you please let me know what am I missing, if anything, or apply this
patch otherwise?

 Thanks in advance,

Attachment: remove-unnecessary-definitions-of-pure-virtual-function.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]