Re: [lmi] Please review commit a929271

[Vadim Zeitlin]

On Wed, 31 Jan 2018 23:25:40 +0000 Greg Chicares <address@hidden> wrote:

GC> Vadim--please tell me if there's anything you don't like about my
GC> commit a929271.

 I've actually already looked at it when I received the commit email
notification and didn't see anything wrong with it, quite the contrary: I
hesitated to send a more-or-less content-free email thanking you for fixing
my bug. As you can see, I finally decided against it, but now that you've
explicitly asked, let me indeed express my thanks and say that I'm sorry
for forgetting to add this variable in the first place.

 I also wonder if it could be worth adding a script/commit hook/make target
checking that all the variables present in .mst files are at least
mentioned in the C++ code too. What do you think?

GC> I'm quite sure it works correctly, but what I don't know is whether my
GC> change stomped on some internal logic governing the order of
GC> add_variable() statements.

 No. As you probably noticed, I couldn't really decide on any order used
for these variables. I tried to group them in related (in my, maybe
mistaken, view) clusters and order them alphabetically inside each cluster,
but I'm not even sure if I followed this vaguely defined rule everywhere.
And you could almost surely define a better one if you think it would be
worth rearranging them.

 Regards,
VZ