Re: [lmi] [lmi-commits] master 4c21bf7 6/6: Replace shared_ptr with unique_ptr

[Greg Chicares]

On 2018-10-16 13:44, Vadim Zeitlin wrote:
> On Tue, 16 Oct 2018 09:19:10 -0400 (EDT) Greg Chicares <address@hidden> wrote:
[...]
> GC> +#include "group_quote_pdf_gen.hpp"      // [required for unique_ptr<>]
> 
>  I'd just like to notice that this header is only required here because of
> the inline definition of dtor of ledger_emitter, which has a
> unique_ptr<group_quote_pdf_gen> member, in this file:
> 
>     ~ledger_emitter() = default;
> 
> If we just declared the dtor here but moved its definition to
> emit_ledger.cpp, it wouldn't require including group_quote_pdf_gen.hpp
> from this header.
> 
>  Of course, in practice this probably doesn't make much difference as
> group_quote_pdf_gen.hpp doesn't change often, so including it shouldn't
> result in recompiling more files, but it might be still better to avoid the
> not-really-required header inclusion from general tidiness point of view.

Tidiness sounds like mere aesthetics; but physical design is important.
Done in d2b8c019. Thanks.