Re: [lmi] [PATCH] Add LMI_ASSERT_MESSAGE() macro

[Vadim Zeitlin]

On Thu, 30 Apr 2020 19:42:03 +0000 Greg Chicares <address@hidden> wrote:

GC> On 2020-04-29 22:42, Greg Chicares wrote:
GC> 
GC> [...unit test for LMI_ASSERT_WITH_MSG...]
GC> 
GC> > Now the unit test fails with gcc-9 (log below). Can you see
GC> > any tidy way to fix it so that it works with both old and
GC> > new versions of gcc?
GC> 
GC> I believe 45051a5e is exactly the right solution.

 Thanks for fixing this and sorry for not having had time to look at it
myself yet. FWIW I started searching for the change in __LINE__ behaviour
between gcc 8 and 9 and didn't find anything relevant in the changelog.
Moreover, I couldn't reproduce this problem in a simple self-contained test
case, unlike the other one, when I tried to do it yesterday, so I still
don't really understand what exactly has changed here and why does lmi seem
to be the only project to have run into it.

 It's probably not worth spending more time on this if you've just removed
the use of __LINE__ in this macro anyhow (and I hope we can switch to
std::source_location in some not so distant future), but please let me know
if you think otherwise.

 Thanks,
VZ

pgpbRiPVarz6q.pgp
Description: PGP signature