RE: [LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void)

[Kevin Wells]

Hi Henry,

 

Yes, this seems to be a cut and paste bug in the 2.6.34 release only for SIC1 and SIC2 ATR and APR registers.

It looks like it works because those registers are re-updated with the correct values later in the set_default_mappings() function, but this is un-intended code.

Thanks for reporting this! I’ll clean this up in the next patch series. If you already have a patch for this, could you post it on the patch forums?

 

thanks

Kevin

 

From: address@hidden [mailto:address@hidden On Behalf Of Li Yuan-Lung
Sent: Monday, January 24, 2011 9:57 PM
To: Kevin Wells; address@hidden
Subject: [LTIB] LPC3250: Some mistakes(maybe) in lpc32xx_init_irq(void)

 

Dear Kevin,
Forgot to tell you that I just found this strange code in IRQ init of lpc32xx series last month.
In void __init lpc32xx_init_irq(void), please kindly see the attachment.

The "MIC_APR_DEFAULT" and "MIC_ATR_DEFAULT" was used in SIC1 and SIC2 init. I also see "SIC1_ATR_DEFAULT" and "SIC2_ATR_DEFAULT" defined but never been referenced. I didn't check detail meaning of each bit. I guess this migh be the copy-paste typo.


--
Best Regards,

Henry Li
SW Engineer of Climax Co.
TEL: +886-2-2794-0001 ext.231
FAX: +886-2-2792-6618