ltib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Ltib] Ltibutils.pm: test for zlib installation


From: Sale, Devin M
Subject: Re: [Ltib] Ltibutils.pm: test for zlib installation
Date: Wed, 3 Jul 2013 11:43:05 +0000

Hi,

Here's what I was running into during an install of Freescale's latest BSP 
L3.0.35_4.0.0_130424_source.tar.gz on Ubuntu 12.04

In Ubuntu 12.04 the location of zlib moved, but zlib-devel did not.
zlib has two matches for libz.so* (file and symlink) and zlib-devel adds 
another (file).

Both zlib and zlib-devel are required packages as defined in ./ltib's list.

My initial thought was that it only needs one library to link against e.g. 
zlib-devel.
But I guess I don't know that for sure.
If all are required maybe ltib should check for 3.

Anyway, I added the path instead of changing the file count limit.

------
>From 6629f1e152f872051dabee8289d815abd70c9dd5 Mon Sep 17 00:00:00 2001
From: Devin Sale <address@hidden>
Date: Thu, 20 Jun 2013 08:50:38 -0400
Subject: [PATCH 1/5] ltib add path to libz check on ubuntu 12.04

Added path to ltib installation check for the presence of libz.

ltib checks for libz installation by looking for libz.so* in a hard
coded list of the paths.  If there are two or more listings (one
for the lib and one for the real name and one for the fully-qualified
soname) the check is satisfied.
Everytime the path for libz moves in a new host linux distribution
this list of paths needs updated.
---
 bin/Ltibutils.pm |    1 +
 1 file changed, 1 insertion(+)

diff --git a/bin/Ltibutils.pm b/bin/Ltibutils.pm
index b804eaa..33abee8 100755
--- a/bin/Ltibutils.pm
+++ b/bin/Ltibutils.pm
@@ -584,6 +584,7 @@ TXT
                     },
     zlib         => sub { my @f = (glob('/usr/lib/libz.so*'),
                                    glob('/lib/libz.so*'),
+                                   glob('/lib/i386-linux-gnu/libz.so*'),
                                    glob('/lib64/libz.so*'),
                                    glob('/usr/lib/i386-linux-gnu/libz.so*'),
                                    glob('/usr/lib32/libz.so*'),
--
1.7.9.5

Devin

-----Original Message-----
From: address@hidden [mailto:address@hidden On Behalf Of Stuart Hughes
Sent: Saturday, June 22, 2013 7:14 AM
To: Mike Goins
Cc: address@hidden
Subject: Re: [Ltib] Ltibutils.pm: test for zlib installation

Hi Mike,

I can't remember whether or not that was deliberate.  I think it was.
The idea is that it's looking for a symlink and the file it points to,
so there should be 2 (at least).

Regards, Stuart

On 21/06/13 00:06, Mike Goins wrote:
> On Thu, Jun 20, 2013 at 3:29 PM, Stuart Hughes <address@hidden> wrote:
>> Hi Devin,
>>
>> The idea is to check all the possible locations, not just
>> '/usr/lib/x86_64-linux-gnu/libz.so*' because the location varies from
>> distribution to distribution.
>>
>> Regards, Stuart
>
>
> I think the OP implied:
>
> Index: bin/Ltibutils.pm
> ===================================================================
> RCS file: /sources/ltib/ltib/bin/Ltibutils.pm,v
> retrieving revision 1.38
> diff -u -r1.38 Ltibutils.pm
> --- bin/Ltibutils.pm 7 Aug 2011 15:05:53 -0000 1.38
> +++ bin/Ltibutils.pm 20 Jun 2013 23:04:22 -0000
> @@ -591,7 +591,7 @@
>                                     glob('/lib/i386-linux-gnu/libz.so*'),
>                                     
> glob('/usr/lib/x86_64-linux-gnu/libz.so*'),
>                                     glob('/lib/x86_64-linux-gnu/libz.so*'));
> -                                   @f > 1 ? 1 : 0 },
> +                                   @f > 0 ? 1 : 0 },
>      'zlib-devel' => sub { -f '/usr/include/zlib.h' },
>  };
>
>
>
>> On 19/06/13 20:53, Sale, Devin M wrote:
>>> Hello,
>>>
>>> In Ltibutils.pm there's a routine to check for the existence of libz.so* in 
>>> a list of paths:
>>>
>>>     zlib         => sub { my @f = (glob('/usr/lib/libz.so*'),
>>>                                    glob('/lib/libz.so*'),
>>>                                    glob('/lib64/libz.so*'),
>>>                                    glob('/usr/lib/i386-linux-gnu/libz.so*'),
>>>                                    glob('/usr/lib32/libz.so*'),
>>>                                    
>>> glob('/usr/lib/x86_64-linux-gnu/libz.so*') ); @f > 1 ? 1 : 0 },
>>>
>>> Shouldn't the check be
>>>                                    
>>> glob('/usr/lib/x86_64-linux-gnu/libz.so*') ); @f > 0 ? 1 : 0 },
>>>
>>> Since only one instance of libz is required.
>>>
>>> Devin
>>> ****************************************************************************************
>>>  Note: If the reader of this message is not the intended recipient, or an 
>>> employee or agent responsible for delivering this message to the intended 
>>> recipient, you are hereby notified that any dissemination, distribution or 
>>> copying of this communication is strictly prohibited. If you have received 
>>> this communication in error, please notify us immediately by replying to 
>>> the message and deleting it from your computer. Thank you. 
>>> ****************************************************************************************
>>>
>>>
>>> _______________________________________________
>>> LTIB home page: http://ltib.org
>>>
>>> Ltib mailing list
>>> address@hidden
>>> https://lists.nongnu.org/mailman/listinfo/ltib
>>>
>>
>> _______________________________________________
>> LTIB home page: http://ltib.org
>>
>> Ltib mailing list
>> address@hidden
>> https://lists.nongnu.org/mailman/listinfo/ltib
>
> _______________________________________________
> LTIB home page: http://ltib.org
>
> Ltib mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/ltib
>

_______________________________________________
LTIB home page: http://ltib.org

Ltib mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/ltib

****************************************************************************************
 Note: If the reader of this message is not the intended recipient, or an 
employee or agent responsible for delivering this message to the intended 
recipient, you are hereby notified that any dissemination, distribution or 
copying of this communication is strictly prohibited. If you have received this 
communication in error, please notify us immediately by replying to the message 
and deleting it from your computer. Thank you. 
****************************************************************************************




reply via email to

[Prev in Thread] Current Thread [Next in Thread]