[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, up

From: Sylvain Rochet
Subject: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. 4b035b99024d9283a5f8fd8354ae4abdee7cc8dc
Date: Wed, 11 Mar 2015 00:22:18 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  4b035b99024d9283a5f8fd8354ae4abdee7cc8dc (commit)
       via  9778b1411c5af07622819cd8f62bfbb3bac71eb4 (commit)
       via  636ff411f19e11bd45a7cf1df5f189654a7a9dd2 (commit)
       via  02598d1e917d0de0b67017b19c019e30d1b6b7a4 (commit)
       via  31aea3c9969661eb1debac8d251e5af1dd3b517f (commit)
       via  a60f2588d68e263a2299b44397da4e9209426492 (commit)
       via  d518f5f307170aa6494fca1977797f39f258a2cb (commit)
       via  d5cbacba502dc534b8ffe7b4145d57c8316db4ea (commit)
       via  ab0f3da650d691f396209ec09ab16e1fc8adf698 (commit)
       via  52de24b95b0747e408d59b4210493011f03b01bc (commit)
       via  70b60bbe16089b03d2c85e96025569a60f50b888 (commit)
      from  aff890bce82f3477b3a05c073509445c065d6b2a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4b035b99024d9283a5f8fd8354ae4abdee7cc8dc
Author: Sylvain Rochet <address@hidden>
Date:   Wed Mar 11 01:20:53 2015 +0100

    PPP, PPPoS, PPP_INPROC_MULTITHREADED defaults to 0, explain thread safety 
issue with it

commit 9778b1411c5af07622819cd8f62bfbb3bac71eb4
Author: Sylvain Rochet <address@hidden>
Date:   Wed Mar 11 00:58:09 2015 +0100

    PPP, PPPoS, TCPIP: add packet input path for point to point interfaces 
(only PPPoS for now) through the TCPIP API
    !NO_SYS users may now use as well the TCPIP API for PPPoS input data,
    this way they can disable PPP_INPROC_MULTITHREADED and run pppos_input()
    inside the lwIP thread, which fixes, at least for them, all the
    threading issues related to PPP_INPROC_MULTITHREADED.

commit 636ff411f19e11bd45a7cf1df5f189654a7a9dd2
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 23:58:16 2015 +0100

    PPP, PPPoS, improve the freeing of remaining RX pbuf if 
    If PPP_INPROC_MULTITHREADED is not enabled, we can free unfinished
    RX pbuf from the pppos_disconnect() function because pppos_input()
    is running in the same context. Thanks to the pppos->open flags we
    now only need to free remaining pbuf in the disconnect function
    if PPP_INPROC_MULTITHREADED is not enabled.

commit 02598d1e917d0de0b67017b19c019e30d1b6b7a4
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 23:51:32 2015 +0100

    PPP, PPPoS, moved pcomp and accomp only used by PPPoS to PPPoS

commit 31aea3c9969661eb1debac8d251e5af1dd3b517f
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 23:41:15 2015 +0100

    PPP, PPPoS, moved vj_enabled flag from PPP CORE to PPPoS
    Now that we have flags in PPPoS, moved vj_enabled only used for PPPoS to

commit a60f2588d68e263a2299b44397da4e9209426492
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 23:34:11 2015 +0100

    PPP, PPPoE and PPPoL2TP, removed ppp->pcomp usage
    We refuse protocol compression in both PPPoE and PPPoL2TP, therefore
    ppp->pcomp can't be true, removed.

commit d518f5f307170aa6494fca1977797f39f258a2cb
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 22:52:35 2015 +0100

    PPP, PPPoS, improve thread safety of pppos_input()
    Don't process input data if PPPoS is closed, it helps using
    pppos_input() from a different context to prevent pppos_input() to
    modify PPPoS RX machine state on a closed PPPoS session. It also
    prevents allocating pbuf (which are going to be tossed out by PPP core)
    and parsing serial input on a closed session.
    It only mitigates the fact that this function is actually NOT thread
    safe in absolutely all cases, it does not fix it but it helps for a low
    For example user application should never call pppos_input() while
    pppos_connect() or pppos_listen() is currently running because both of
    them are freeing any input pbuf left over from the last session before
    resetting the PPPoS state, they really have to to prevent pbuf leaks.
    We cannot fix that easily because we don't have spinlock with an
    irqsave/irqrestore helper for IRQ contexts. Mutex cannot be used in
    interrupt contexts (or again, with an IRQ mutex helper).
    We are going to improve the documentation on this point.

commit d5cbacba502dc534b8ffe7b4145d57c8316db4ea
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 22:35:04 2015 +0100

    PPP, PPPoS, don't protect pppos->in_accm if PPP_INPROC_MULTITHREADED is not 
    If pppos_input() is used without PPP_INPROC_MULTITHREADED, then 
    is running in the lwIP context, we don't need to protect anything.

commit ab0f3da650d691f396209ec09ab16e1fc8adf698
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 01:08:38 2015 +0100

    Revert "PPP, PPPoS, fixed thread safety of pppos_input()"
    This reverts commit ea58a8103ceb70d20b88d37bfdbbe8ce8e9c6e71.

commit 52de24b95b0747e408d59b4210493011f03b01bc
Author: Sylvain Rochet <address@hidden>
Date:   Tue Mar 10 01:08:34 2015 +0100

    Revert "PPP, PPPoS, added necessary comment about mutex"
    This reverts commit b23a6172edd50a53bd8e79929a8ee5899c8e6d46.

commit 70b60bbe16089b03d2c85e96025569a60f50b888
Author: Sylvain Rochet <address@hidden>
Date:   Mon Mar 9 23:14:30 2015 +0100

    PPP, display correct pbuf size in ppp_input() debug messages


Summary of changes:
 src/api/tcpip.c                  |    7 ++
 src/include/lwip/opt.h           |   16 +++-
 src/include/netif/ppp/ppp.h      |   11 +--
 src/include/netif/ppp/ppp_impl.h |    4 +-
 src/include/netif/ppp/pppos.h    |   14 +++-
 src/netif/ppp/ppp.c              |   13 +--
 src/netif/ppp/pppoe.c            |    8 +-
 src/netif/ppp/pppol2tp.c         |    8 +-
 src/netif/ppp/pppos.c            |  153 ++++++++++++++++++++++----------------
 9 files changed, 133 insertions(+), 101 deletions(-)

lwIP - A Lightweight TCPIP stack

reply via email to

[Prev in Thread] Current Thread [Next in Thread]