[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. dde55c6c0efcdf3869416c1c2231488e33ca9343

[Sylvain Rochet]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  dde55c6c0efcdf3869416c1c2231488e33ca9343 (commit)
      from  5d22679c6708d560b45b89844dad6e615d0487a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit dde55c6c0efcdf3869416c1c2231488e33ca9343
Author: Sylvain Rochet <address@hidden>
Date:   Sat Nov 5 21:34:23 2016 +0100

    PPP, IPCP: fix reset state before reconnecting
    
    Commit 7df5496e7b revealed a regression introduced in commit 5a71509353
    which broke IPCP reset state.
    
    ask_for_local was set to 0 if ouraddr initial value is 0, if
    ask_for_local was false go->ouraddr was cleared in reset callback,
    commit 5a71509353 breaks it by removing this clearing. This regression
    was silent because the whole ppp pcb runtime data was cleared before
    reconnecting until commit 7df5496e7b which removed this giant clearing.
    
    Fix it by reintroducing ask_for_local boolean value, with proper initial
    value following what unused function ip_check_options do.
    
    Fixes: 7df5496e7b ("PPP, rework initial/reconnect cleanup")
    Fixes: 5a71509353 ("PPP, CORE, IPCP: removed useless ask_for_local boolean")

-----------------------------------------------------------------------

Summary of changes:
 src/include/netif/ppp/ppp.h |    4 +++-
 src/netif/ppp/ipcp.c        |    7 +------
 2 files changed, 4 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack