[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master

From: Joel Cunningham
Subject: Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-998-g98d5e06
Date: Mon, 23 Oct 2017 08:33:02 -0500


On Oct 22, 2017, at 2:30 PM, Dirk Ziegelmeier <address@hidden> wrote:

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
      via  98d5e06dba396e02e7300fe348987f31c1447d01 (commit)
      via  a7f2ef4aec3cec5add28f35e9543f043732382e5 (commit)
     from  ddcf9cc764bff1c68c990a016ebe5b7f5ccba22d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 98d5e06dba396e02e7300fe348987f31c1447d01
Author: Dirk Ziegelmeier <address@hidden>
Date:   Sun Oct 22 21:27:32 2017 +0200

   Silence gcc 7 warning about fall-through in case statement by adding a comment

commit a7f2ef4aec3cec5add28f35e9543f043732382e5
Author: Dirk Ziegelmeier <address@hidden>
Date:   Sun Oct 22 21:26:57 2017 +0200

   Fix two bad "fall-through” code

Out of curiosity, I took a look at the fall-through change and noticed this is actually a regression. NETCONN_EVT_RCVMINUS and NETCONN_EVT_SENDPLUS were not meant to fall through to the below cases.

There has been some cleanup work in this function over the last year and it looks like the regression was introduced in c5db278746daedcc6566822992f3f33ce3801470 which attempted to remove the gotos, but looks like the lack of ‘break’ was over-looked.

I can push a fix if you’d like or feel free to yourself :)


Summary of changes:
src/api/sockets.c     | 4 ++++
src/netif/ppp/pppos.c | 5 ++++-
2 files changed, 8 insertions(+), 1 deletion(-)

lwIP - A Lightweight TCPIP stack

lwip-commits mailing list


reply via email to

[Prev in Thread] Current Thread [Next in Thread]