lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] LWIP_U32_DIFF is unnecessarily complex


From: Simon Goldschmidt
Subject: Re: [lwip-devel] LWIP_U32_DIFF is unnecessarily complex
Date: Thu, 24 Nov 2011 10:42:16 +0100

David Brown <address@hidden> wrote:
> In that case, I think the comment is wrong - an easily misinterpreted 
> comment is worse than no comment.  And the name of the macro is also 
> wrong, since it is only targeted at specific circumstances rather than 
> being a general "difference" macro.

That's why both the macro and the comment have already been removed in the 
current sources ...

> When you know that a is "higher" than b, in the sense used here, then 
> the difference is just (a - b) in unsigned arithmetic.

... and the sources just use (a - b) by now (as I wrote yesterday).


Simon
-- 
Empfehlen Sie GMX DSL Ihren Freunden und Bekannten und wir
belohnen Sie mit bis zu 50,- Euro! https://freundschaftswerbung.gmx.de



reply via email to

[Prev in Thread] Current Thread [Next in Thread]