[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9274] SNMPv3 improvements
From: |
Simon Goldschmidt |
Subject: |
[lwip-devel] [patch #9274] SNMPv3 improvements |
Date: |
Wed, 1 Mar 2017 14:53:48 -0500 (EST) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 |
Follow-up Comment #3, patch #9274 (project lwip):
I have some things to add (if only for the next patches):
- 2 spaces, not tabs!
- C comments, not C++!
- the name "tcpip_enginetime_timer()" is not appropriate for snmpv3_priv.h
The rest looks good ;-) (from viewing the code, not testing)
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9274>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #9274] SNMPv3 improvements, Marco Veeneman, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements, Marco Veeneman, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements, Marco Veeneman, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements, Marco Veeneman, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements, Dirk Ziegelmeier, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements,
Simon Goldschmidt <=
- [lwip-devel] [patch #9274] SNMPv3 improvements, Simon Goldschmidt, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements, Dirk Ziegelmeier, 2017/03/01
- [lwip-devel] [patch #9274] SNMPv3 improvements, Marco Veeneman, 2017/03/02