|
From: | Joel Cunningham |
Subject: | [lwip-devel] [bug #50614] TCP: new ACK processing, unsent queue check and pcb->sndbuf update in wrong spot |
Date: | Wed, 22 Mar 2017 18:02:39 -0400 (EDT) |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 |
Follow-up Comment #1, bug #50614 (project lwip): Attached is patch doing two things: 1) moves unsent queue check and pcb->snd_buf update inside the conditional for new data ACK 2) unsent queue check can now use TCP_SEQ_LEQ rather than TCP_SEQ_BETWEEN because ackno has already been checked against pcb->snd_nxt This ends up being a very minor performance improvement for duplicate ACKs because we aren't doing these checks. Also a minor improvement by switching to TCP_SEQ_LEQ for each segment on the unsent queue that is acknowledged Please scrutinize the patch to make sure I haven't over looked something since this code is very old :) (file #40082) _______________________________________________________ Additional Item Attachment: File name: 0001-bug-50614-move-unsent-queue-check-pcb-snd_buf-update.patch Size:5 KB _______________________________________________________ Reply to this item at: <http://savannah.nongnu.org/bugs/?50614> _______________________________________________ Message sent via/by Savannah http://savannah.nongnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |