[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #52763] mdns: move data off the stack and dynamically

From: Simon Goldschmidt
Subject: [lwip-devel] [bug #52763] mdns: move data off the stack and dynamically allocate data.
Date: Wed, 3 Jan 2018 09:44:16 -0500 (EST)
User-agent: Mozilla/5.0 (iPad; CPU OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Version/10.0 Mobile/14A456 Safari/602.1

Follow-up Comment #10, bug #52763 (project lwip):

Up to now, worst case calculation was deliberately used in lwIP to prevent
"random" allocation failures when the heap gets empty. That's why we have
pools. And you can use the heap to emulate the pools if you want to. However,
I'm not comfortable with using mem_malloc all over the place. We have to let
people configure the allocation scheme. You're the best example for that. But
you can't enforce your allocaton scheme to all users of lwip. We have to find
a way that fits all.

Regarding strndup: your comment about using it worries me a little. LwIP does
*not* use the C heap! (Or only if you configure it to.) Strndup uses malloc,
so it's a no-go!

And regarding the separatoin of big changes into small commits: I also think
it's important to have one issue solved per commit. That doesn't mean commits
have to be small, but mixing things in one commit makes it really difficult to
see what has change why when you look at it ten years later...


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]