[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9533] sys_check_timeouts: recalculate the time diff
[lwip-devel] [patch #9533] sys_check_timeouts: recalculate the time diff after each handler call
Sat, 6 Jan 2018 16:25:52 -0500 (EST)
Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Follow-up Comment #2, patch #9533 (project lwip):
> Won't do: when checking in every loop, there's a risk we can loop endlessly.
This was not the main bug fixed, see the first paragraph. Without some work
here, such as this patch, it seem broken. However if people want to move to
using absolute times then that makes this obsolete anyway, and there I agree
it seems best to sample sys_now only once.
The code can still get caught in a cycle processing timeouts, but in
sys_timeouts_mbox_fetch, it calls sys_timeouts_sleeptime() and keeps looping
while this is triggered, so if that is a big concern then perhaps it needs to
bail out after a given number of loops to look at the mail box too.
Reply to this item at:
Message sent via/by Savannah