[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #9581] Add "server reachability" register to SNTP
|
From: |
Simon Goldschmidt |
|
Subject: |
[lwip-devel] [patch #9581] Add "server reachability" register to SNTP |
|
Date: |
Tue, 13 Mar 2018 16:05:19 -0400 (EDT) |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36 |
Follow-up Comment #1, patch #9581 (project lwip):
Thre things:
a) the reachability variable does not have to be set to zero in the init
function, C startup code does this for you (sntp_pcb is not set to zero,
either)
b) a patch instead of files is far better. When changes are made to sntp
before your patch gets applied, it can get difficult to see what you actually
changed
c) the 'reachability' variable is global but we have more than one server. Is
this intended by the RFC you cited? (I'm too lazy to search for it right now)
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?9581>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/