Re: [lwip-devel] 2.1.x bugfix branch updated

[Simon Goldschmidt]

Axel Lin wrote:
> Simon Goldschmidt <address@hidden> 於 2019年2月26日 週二 下午11:48寫道：
> >
> > Axel Lin wrote:
> > > Simon Goldschmidt <address@hidden> 於 2019年2月18日 週一 下午8:51寫道：
> > > >
> > > > Hi all,
> > > >
> > > > the 2.1.x branch [1] just got about 20 or so bugfix cherry-picks.
> > > > This means I'd like to release 2.1.3 shortly. Please test :-)
> > >
> > > Hi Simon,
> > > Is below commit also required for stable-2.1.x?
> > > http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=2ff0db9a9b047d1c94ddbeea010561d1b9032101
> > > It was reported on
> > > http://lists.nongnu.org/archive/html/lwip-devel/2018-11/msg00073.html
> >
> > Yes. I've cherry-picked that one also. Plus an updated fix for this.
> Hi Simon,
> Now I got below build issue in both master and stable-2.1.x branch:
> 
> ../../../../src/core/udp.c: In function ‘udp_bind’:
> ../../../../src/core/udp.c:999:42: error: suggest parentheses around
> ‘&&’ within ‘||’ [-Werror=parentheses]
>            if ((ipcb->local_port == port) &&
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>                ((IP_GET_TYPE(&ipcb->local_ip) == IP_GET_TYPE(ipaddr)) &&
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                /* IP address matches or any IP used? */
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                (ip_addr_cmp(&ipcb->local_ip, ipaddr) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                ip_addr_isany(ipaddr) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~
>                ip_addr_isany(&ipcb->local_ip))) ||
>                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> /home/axel/git/lwip/lwip/contrib/ports/unix/../Common.allports.mk:91:
> recipe for target 'udp.o' failed
> make: *** [udp.o] Error 1

Should be fixed in master and stable branches. Thanks for reporting.

Regards,
Simon