[lwip-devel] [bug #57706] dhcp/acd integration: acd is not stopped

[Jasper Verschueren]

Follow-up Comment #3, bug #57706 (project lwip):

I agree with the patch made and I applied it on top of the latest master. The
attached patch does apply cleanly.

I'm not convinced that we should adc_remove() from dhcp_stop().
The function dhcp_release_and_stop() called by dhcp_stop() does not change
anything to the allocated memory. 
The dhcp struct is just put in an off state.
So I do not see invalid memory access happening.

However the functions were we do unallocate memory should include something
like adc_remove(). I'm thinking of dhcp_cleanup().

I do not use dhcp_cleanup() as I use dhcp_set_struct().
I suggest making an adc_remove function and adding it to dhcp_cleanup.
For the people that use dhcp_set_struct, a warning could be added in comments.


What do you think?

(file #49013)
    _______________________________________________________

Additional Item Attachment:

File name: 0001-dhcp-stop-acd-module-when-stopping-dhcp.patch Size:1 KB
   
<https://savannah.nongnu.org/file/0001-dhcp-stop-acd-module-when-stopping-dhcp.patch?file_id=49013>



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?57706>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/