lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] Desiderata for 2.2.0: (1) fix slipif undefined refs


From: address@hidden
Subject: Re: [lwip-devel] Desiderata for 2.2.0: (1) fix slipif undefined refs
Date: Tue, 17 Jan 2023 21:10:56 +0100
User-agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1

Am 17.01.2023 um 18:54 schrieb Renzo Davoli:
Hi,

On Sat, Jan 14, 2023 at 06:43:02PM +0100, Joan Lledó via lwip-devel wrote:
Hi,
El 8/1/23 a les 19:10, Renzo Davoli ha escrit:
You are right. This approach was to minimize the impact for the other
architectures that may include src/Filelists.cmake.
Any other way to exclude slipif fits, e.g. a cmake variable used as a flag,
say if LWIP_EXCLUDE_SLIPIF is set slipif.c is *not* added.
I don't have a strong opinion, if the alternatives are too complex it's OK
for me to apply the patch as it is.

The new patch using a flag named LWIP_EXCLUDE_SLIPIF is here attached.

Looks good to me, I'll just add a comment to src/Filelists.cmake when
appliying.

Regards,
Simon



reply via email to

[Prev in Thread] Current Thread [Next in Thread]