[lwip-devel] [patch #10311] Fix altcp.h's altcp_get_tcp_addrinfo define for regular TCP

[Shawn Silverman]

URL:
  <https://savannah.nongnu.org/patch/?10311>

                 Summary: Fix altcp.h's altcp_get_tcp_addrinfo define for
regular TCP
                 Project: lwIP - A Lightweight TCP/IP stack
               Submitter: ssilverman
               Submitted: Mon 30 Jan 2023 04:57:26 AM UTC
                Category: TCP
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Mon 30 Jan 2023 04:57:26 AM UTC By: Shawn Silverman <ssilverman>
To be consistent, the function defined in tcp.h should probably be changed to
`tcp_get_tcp_addrinfo()` (from `tcp_tcp_get_tcp_addrinfo()`), but the attached
way seemed the easiest way to fix the problem without requiring code changes
to projects that already use lwIP. It does violate the "just add 'al' to the
function name" principle, however, so maybe changing the name in tcp.h is
actually better?

A third option is to change the altcp version's function name to
`altcp_tcp_get_tcp_addrinfo()`, however there's already a static function
defined with that name, so that might add some confusion and other compile
issues because of that define being included (via altcp.h) in altcp_tcp.c.






    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Mon 30 Jan 2023 04:57:26 AM UTC  Name:
0001-Fix-altcp.h-s-altcp_get_tcp_addrinfo-define-for-regu.patch  Size: 889B  
By: ssilverman

<http://savannah.nongnu.org/patch/download.php?file_id=54286>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10311>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/