[lwip-users] [lwip] Fixes for buglets in api_lib.c [patch]

[Duncan Palmer]

--Boundary_(ID_SAG6ErhYXwZCyGX4LerAfw)
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: quoted-printable

Some of the return statements don't really return what they're intended t=
o.

Patch attached...

--Boundary_(ID_SAG6ErhYXwZCyGX4LerAfw)
Content-type: text/plain; name=lwipdiff.out; charset=iso-8859-1
Content-disposition: attachment; filename=lwipdiff.out
Content-transfer-encoding: 8bit

--- lwip-cvs-20020529/src/api/api_lib.c Wed May 29 15:00:16 2002
+++ tcpip/src/api/api_lib.c     Thu Jun 13 18:51:51 2002
@@ -337,7 +337,8 @@
   }
   
   if((msg = memp_mallocp(MEMP_API_MSG)) == NULL) {
-    return (conn->err = ERR_MEM);
+    conn->err = ERR_MEM;
+    return conn->err;
   }
   msg->type = API_MSG_BIND;
   msg->msg.conn = conn;
@@ -396,7 +397,8 @@
   }
   
   if((msg = memp_mallocp(MEMP_API_MSG)) == NULL) {
-    return (conn->err = ERR_MEM);
+    conn->err = ERR_MEM;
+    return conn->err;
   }
   msg->type = API_MSG_LISTEN;
   msg->msg.conn = conn;
@@ -513,7 +515,8 @@
   }
 
   if((msg = memp_mallocp(MEMP_API_MSG)) == NULL) {
-    return (conn->err = ERR_MEM);
+    conn->err = ERR_MEM;
+    return conn->err;
   }
 
   DEBUGF(API_LIB_DEBUG, ("netconn_send: sending %d bytes\n", buf->p->tot_len));
@@ -549,7 +552,8 @@
   }
 
   if((msg = memp_mallocp(MEMP_API_MSG)) == NULL) {
-    return (conn->err = ERR_MEM);
+    conn->err = ERR_MEM;
+    return conn->err;
   }
   msg->type = API_MSG_WRITE;
   msg->msg.conn = conn;
@@ -611,7 +615,8 @@
     return ERR_VAL;
   }
   if((msg = memp_mallocp(MEMP_API_MSG)) == NULL) {
-    return (conn->err = ERR_MEM);
+    conn->err = ERR_MEM;
+    return conn->err;
   }
 
   conn->state = NETCONN_CLOSE;

--Boundary_(ID_SAG6ErhYXwZCyGX4LerAfw)--
[This message was sent through the lwip discussion list.]