[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [lwip-users] Patch for IGMP V1/V2 and raw multicast support
From: |
Mace Gael |
Subject: |
RE: [lwip-users] Patch for IGMP V1/V2 and raw multicast support |
Date: |
Tue, 28 Mar 2006 14:33:26 +0200 |
Christiaan Simons:
> The contributed IGMP + Altera code won't work out of the box for the raw
> API + NO_SYS case.
Okay. I'll try to make the modification against the official release version
1.1.0.
> There are a few assumptions on having a sys_arch
> ( sys_timeout() in igmp.c and etharp.c ),
> therefore it isn't entirely "in the spirit of LWIP".
Do you have any advice to implement a timeout handler?
> Also I miss some return value checks on mem_malloc().
Could you point out to me the various issues you noticed.
> It would be nice if these issues are solved first.
I'll try to do my best.
> >From my perspective "the spirit of LWIP" is:
>
> * Raw-API first, additional layers and API's can be
> nice but should not collide or invade in the basic API.
> * Robust, portable code.
Except the issues you noticed, what it's your feeling about the implementation
of IGMP/Multicast layer I propose, in term of integration
in LWIP?
What do you mean by additional layers? Because I don't see what could be
qualify as "additional layers" in the code I propose.
Gaƫl