[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE : [lwip-users] Bug in inet_chksum_pseudo() produces badchecksum(Parad
From: |
Frédéric BERNON |
Subject: |
RE : [lwip-users] Bug in inet_chksum_pseudo() produces badchecksum(Paradigm C++) |
Date: |
Tue, 28 Aug 2007 12:04:26 +0200 |
So, we restore last changes in their original form (number 1)? Do you want I do
it?
====================================
Frédéric BERNON
HYMATOM SA
Chef de projet informatique
Microsoft Certified Professional
Tél. : +33 (0)4-67-87-61-10
Fax. : +33 (0)4-67-70-85-44
Email : address@hidden
Web Site : http://www.hymatom.fr
====================================
P Avant d'imprimer, penser à l'environnement
-----Message d'origine-----
De : address@hidden [mailto:address@hidden De la part de Kieran Mansley
Envoyé : mardi 28 août 2007 10:22
À : Mailing list for lwIP users
Objet : Re: [lwip-users] Bug in inet_chksum_pseudo() produces
badchecksum(Paradigm C++)
On Tue, 2007-08-28 at 10:17 +1200, David Empson wrote:
> Performance issues aside, if I was reading code which did a "greater
> than
> zero" test I would immediately be wondering what was special about the value
> being negative, then discover the 'acc' variable was unsigned, then wonder
> why someone had written it using greater-than instead of not-equal.
>
> My opinion (for what it is worth) is that LWIP should stick with
> either the
> original form (number 1) or the more explicit form (number 2) which has
> already been checked in, but Dave should patch his own copy to work around
> the bug in his compiler.
I agree.
Kieran
_______________________________________________
lwip-users mailing list
address@hidden http://lists.nongnu.org/mailman/listinfo/lwip-users
Frédéric BERNON.vcf
Description: Frédéric BERNON.vcf
- RE : [lwip-users] Bug in inet_chksum_pseudo() produces badchecksum(Paradigm C++),
Frédéric BERNON <=