[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-users] Lots of RAM

From: Valdemar
Subject: Re: [lwip-users] Lots of RAM
Date: Fri, 07 Sep 2007 12:21:08 +0200
User-agent: Thunderbird (Windows/20070728)

Jonathan Larmour skrev:
Frédéric BERNON wrote:

1. When you change the code in a module, could you
   please also make a comment about it in the modules head.
   At least the date of change. As it is now there is no
   way to tell which module is the latest.

I just did a little test with CVS keywords. This feature is enable on Savannah CVS. So, perhaps it could be a solution? Developers, your point of view?

I don't like having revision history in files as it tends to cause false differences when doing 'diff's of trees. Just my one opinion.

If you're using CVS, then all the tracking is done for you anyway. If you don't have that, you are presumably using tarballs, and forgotten which tarball you got the files from, which seems like it's easier to fix for the user than us.

I am not that advanced in using CVS. I just download it and copies
the changed files to my application. I just think that the comments
about a code change should be were the code is changed.

And to Frédéric BERNON:
Yes, my interface runs at 10 Mbits/s, but I tried 100 Mbits/s with
only a very small improvement.
I will study the refernce.

About function names:
   itoa  should be named F_int_to_asc.
   atoi  should be named F_asc_to_int.
   htonl should be named F_host_to_networkorder.

These are all wellknown names and perhaps shouldn't change but
I include them as examples of how I would like it to be.
I also think it is a value in being able to directly distinguish a function name from a variable name by preceeding every function name with "F_".

Germund Asp

reply via email to

[Prev in Thread] Current Thread [Next in Thread]