lwip-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [lwip-users] [PATCH 1/7] lwip: config sanity check for NETIP


From: Goldschmidt Simon
Subject: RE: [lwip-users] [PATCH 1/7] lwip: config sanity check for NETIP
Date: Fri, 21 Sep 2007 08:19:44 +0200

[re: config sanity check for NETIP]
> +#if (LWIP_NETIF_API && !LWIP_TCP)
> +  #error "NETIF API is for TCP"
> +#endif

Why would LWIP_NETIF_API depend on LWIP_TCP? Don't get confused with
tcpip.c vs. tcp.c! Tcpip.c mainly contains a multithreading-wrapper
for the lwIP core and has nothing to do with the TCP protocol
implementation.

[re: report out of memory by pool name indebug:]
If that works, it's a good idea for debugging, I think.

[re: fix build error with LWIP_UDP=0]
I'd rather rely on a check in init.c to solve this.

[re: fix warning: 'packed' attributeignored]
That's strange, I think. I've never seen a compiler warn about this.
But then again, I haven't used gcc4 so far. Can't you simply turn that
warning off? I'm using gcc3 and there are some warnings I can't use
When compiling the lwip code...

Simon




reply via email to

[Prev in Thread] Current Thread [Next in Thread]